Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: James Smart <jsmart2021@gmail.com>, linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2] nvme: Add ctrl attributes for queue_count and sqsize
Date: Wed, 25 Sep 2019 20:28:19 -0700	[thread overview]
Message-ID: <20190926032819.GA13013@C02WT3WMHTD6> (raw)
In-Reply-To: <4d1cea96-1352-eaae-6bee-cc179b2a6400@grimberg.me>

On Wed, Sep 25, 2019 at 05:28:49PM -0700, Sagi Grimberg wrote:
> 
> > v2:
> >    Updated is_visible to not show sqsize attribute on pcie controllers
> 
> Why? isn't sqsize assigned for pci controllers as well?

I only noticed this comment in the 'struct nvme_ctrl' definition:

        /* Fabrics only */
        u16 sqsize;

But since it's been questioned, I see pcie does indeed set this field, and the
code comment was the only source of confusion. So sure, the original patch is
fine in that sense.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2019-09-26  3:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-26  0:20 [PATCH v2] nvme: Add ctrl attributes for queue_count and sqsize James Smart
2019-09-26  0:28 ` Sagi Grimberg
2019-09-26  3:28   ` Keith Busch [this message]
2019-09-26  4:18 ` James Smart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190926032819.GA13013@C02WT3WMHTD6 \
    --to=kbusch@kernel.org \
    --cc=jsmart2021@gmail.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox