From: Max Gurtovoy <maxg@mellanox.com>
To: jgg@mellanox.com, linux-nvme@lists.infradead.org,
sagi@grimberg.me, hch@lst.de, kbusch@kernel.org
Cc: bvanassche@acm.org, vladimirk@mellanox.com, bharat@chelsio.com,
nirranjan@chelsio.com, shlomin@mellanox.com,
krishna2@chelsio.com, Max Gurtovoy <maxg@mellanox.com>
Subject: [PATCH V3 2/3] nvmet-rdma: Implement get_mdts controller op
Date: Sun, 8 Mar 2020 12:55:04 +0200 [thread overview]
Message-ID: <20200308105505.14305-2-maxg@mellanox.com> (raw)
In-Reply-To: <20200308105505.14305-1-maxg@mellanox.com>
Set the maximal data transfer size to be 1MB (currently mdts is
unlimited). This will allow calculating the amount of MR's that
one ctrl should allocate to fulfill it's capabilities.
Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
---
changes from V2:
- move mdts explenation comment to define entry (Sagi)
changes from V1:
- renamed nvmet_rdma_set_mdts to nvmet_rdma_get_mdts
- align to get_mdts callback changes
---
drivers/nvme/target/rdma.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index 37d262a..f47a79b 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -31,6 +31,9 @@
#define NVMET_RDMA_MAX_INLINE_SGE 4
#define NVMET_RDMA_MAX_INLINE_DATA_SIZE max_t(int, SZ_16K, PAGE_SIZE)
+/* Assume mpsmin == device_page_size == 4KB */
+#define NVMET_RDMA_MAX_MDTS 8
+
struct nvmet_rdma_cmd {
struct ib_sge sge[NVMET_RDMA_MAX_INLINE_SGE + 1];
struct ib_cqe cqe;
@@ -1602,6 +1605,11 @@ static void nvmet_rdma_disc_port_addr(struct nvmet_req *req,
}
}
+static u8 nvmet_rdma_get_mdts(const struct nvmet_ctrl *ctrl)
+{
+ return NVMET_RDMA_MAX_MDTS;
+}
+
static const struct nvmet_fabrics_ops nvmet_rdma_ops = {
.owner = THIS_MODULE,
.type = NVMF_TRTYPE_RDMA,
@@ -1612,6 +1620,7 @@ static void nvmet_rdma_disc_port_addr(struct nvmet_req *req,
.queue_response = nvmet_rdma_queue_response,
.delete_ctrl = nvmet_rdma_delete_ctrl,
.disc_traddr = nvmet_rdma_disc_port_addr,
+ .get_mdts = nvmet_rdma_get_mdts,
};
static void nvmet_rdma_remove_one(struct ib_device *ib_device, void *client_data)
--
1.8.3.1
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-03-08 10:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 10:55 [PATCH V3 1/3] nvmet: Add get_mdts op for controllers Max Gurtovoy
2020-03-08 10:55 ` Max Gurtovoy [this message]
2020-03-10 16:50 ` [PATCH V3 2/3] nvmet-rdma: Implement get_mdts controller op Christoph Hellwig
2020-03-08 10:55 ` [PATCH 3/3] nvmet-rdma: allocate RW ctxs according to mdts Max Gurtovoy
2020-03-10 16:50 ` [PATCH V3 1/3] nvmet: Add get_mdts op for controllers Christoph Hellwig
2020-03-10 20:52 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200308105505.14305-2-maxg@mellanox.com \
--to=maxg@mellanox.com \
--cc=bharat@chelsio.com \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=jgg@mellanox.com \
--cc=kbusch@kernel.org \
--cc=krishna2@chelsio.com \
--cc=linux-nvme@lists.infradead.org \
--cc=nirranjan@chelsio.com \
--cc=sagi@grimberg.me \
--cc=shlomin@mellanox.com \
--cc=vladimirk@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox