From: Christoph Hellwig <hch@lst.de>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: sagi@grimberg.me, vladimirk@mellanox.com, bharat@chelsio.com,
nirranjan@chelsio.com, linux-nvme@lists.infradead.org,
shlomin@mellanox.com, jgg@mellanox.com, krishna2@chelsio.com,
kbusch@kernel.org, hch@lst.de, bvanassche@acm.org
Subject: Re: [PATCH V3 1/3] nvmet: Add get_mdts op for controllers
Date: Tue, 10 Mar 2020 17:50:03 +0100 [thread overview]
Message-ID: <20200310165003.GA6986@lst.de> (raw)
In-Reply-To: <20200308105505.14305-1-maxg@mellanox.com>
On Sun, Mar 08, 2020 at 12:55:03PM +0200, Max Gurtovoy wrote:
> Some transports, such as RDMA, would like to set the Maximum Data
> Transfer Size (MDTS) according to device/port/ctrl characteristics.
> This will enable the transport to set the optimal MDTS according to
> controller needs and device capabilities. Add a new nvmet transport
> op that is called during ctrl identification. This will not effect
> transports that don't implement this option. The return value of the new
> op is according to the NVMe spec definition for MDTS.
>
> Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
> Signed-off-by: Israel Rukshin <israelr@mellanox.com>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-03-10 16:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 10:55 [PATCH V3 1/3] nvmet: Add get_mdts op for controllers Max Gurtovoy
2020-03-08 10:55 ` [PATCH V3 2/3] nvmet-rdma: Implement get_mdts controller op Max Gurtovoy
2020-03-10 16:50 ` Christoph Hellwig
2020-03-08 10:55 ` [PATCH 3/3] nvmet-rdma: allocate RW ctxs according to mdts Max Gurtovoy
2020-03-10 16:50 ` Christoph Hellwig [this message]
2020-03-10 20:52 ` [PATCH V3 1/3] nvmet: Add get_mdts op for controllers Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310165003.GA6986@lst.de \
--to=hch@lst.de \
--cc=bharat@chelsio.com \
--cc=bvanassche@acm.org \
--cc=jgg@mellanox.com \
--cc=kbusch@kernel.org \
--cc=krishna2@chelsio.com \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=nirranjan@chelsio.com \
--cc=sagi@grimberg.me \
--cc=shlomin@mellanox.com \
--cc=vladimirk@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox