From: Christoph Hellwig <hch@lst.de>
To: David Fugate <david.fugate@linux.intel.com>
Cc: sagi@grimberg.me, linux-nvme@lists.infradead.org, axboe@fb.com,
kbusch@kernel.org, david.fugate@intel.com,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme: associate stripe size quirk with D4512
Date: Mon, 15 Jun 2020 09:20:31 +0200 [thread overview]
Message-ID: <20200615072031.GA21903@lst.de> (raw)
In-Reply-To: <e2c46dfec9e779d945088b025f833bcd4e29cc1e.camel@linux.intel.com>
On Fri, Jun 12, 2020 at 08:43:15AM -0600, David Fugate wrote:
> On Thu, 2020-06-11 at 07:41 +0200, Christoph Hellwig wrote:
> > On Wed, Jun 10, 2020 at 09:38:36PM -0600, David Fugate wrote:
> > > Intel's D4512 dual-port SSD is based on the older Intel P4500 SSDs
> > > whose development predated the NOIOB feature. Based on a customer
> > > request, the D4512's device ID was changed from the P4500s'. This
> > > patch associates D4512's device ID with the stripe size quirk to
> > > improve its performance.
> >
> > NAK. We've been told Intel forever that we need a standard quirk,
> > and we actually do have way to expose this information in Identify
> > now.
> > Just kick your firmware engineers in the but to set the trivial field
> > in Identify.
>
> Thanks for the feedback Christoph. Our FW engineer for this product is
> currently on vacation, but I'll relay your suggestion to see if it's
> viable.
>
> In the meantime, I'm hearing your rejection for this is simply Intel
> standardized the driver-assisted striping feature as NOIOB and failed
> to realize it in any Intel product. Other than this, was there a
> technical reason for rejecting this patch?
If you look back in the archives we have been unhappy with this quirk for
years and thus helped to standardize it. So we very much expect Intel to
use the standard way to any new product instead of adding more and more
quirks.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-06-15 7:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 3:38 [PATCH] nvme: associate stripe size quirk with D4512 David Fugate
2020-06-11 5:41 ` Christoph Hellwig
2020-06-12 14:43 ` David Fugate
2020-06-15 7:20 ` Christoph Hellwig [this message]
2020-07-02 21:16 ` David Fugate
2020-07-02 21:48 ` Keith Busch
2020-07-02 22:26 ` David Fugate
2020-07-03 20:16 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615072031.GA21903@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=david.fugate@intel.com \
--cc=david.fugate@linux.intel.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox