From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Keith Busch <kbusch@kernel.org>,
hch@lst.de, linux-nvme@lists.infradead.org, sagi@grimberg.me
Subject: Re: [RFC] nvme-mpath: delete disk after last connection
Date: Sun, 27 Sep 2020 08:07:09 +0200 [thread overview]
Message-ID: <20200927060709.GA24024@lst.de> (raw)
In-Reply-To: <f8fdd99f-84da-bf68-a07b-7a6200cc02ab@suse.de>
On Sat, Sep 26, 2020 at 01:16:51PM +0200, Hannes Reinecke wrote:
> I'm okay with that in general, but then again we might run into situations
> where an 'all paths down' scenario is actually expected (think of a
> temporary network outage on nvme-tcp).
> So I guess we need to introduce an additional setting (queue_if_no_path?)
> to be specified during the initial connection.
The original design was pretty much intentional as and all paths down
even usually is temporary. So any change in behavior should be based
on an optional instead of a change in default. And I think the right
way to do implement this would be a timer when to take the gendisk
down, with the default remaining infinitity.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-09-27 6:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 21:38 [RFC] nvme-mpath: delete disk after last connection Keith Busch
2020-09-26 11:16 ` Hannes Reinecke
2020-09-27 6:07 ` Christoph Hellwig [this message]
2020-09-28 14:11 ` Keith Busch
2020-09-29 8:28 ` Sagi Grimberg
2020-09-29 18:08 ` Christoph Hellwig
2020-09-29 18:16 ` Sagi Grimberg
2020-09-30 5:36 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200927060709.GA24024@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox