From: Hannes Reinecke <hare@suse.de>
To: Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>, linux-nvme@lists.infradead.org
Subject: Re: [RFC] nvme-mpath: delete disk after last connection
Date: Wed, 30 Sep 2020 07:36:13 +0200 [thread overview]
Message-ID: <3bd44c2e-ded8-80b8-e2c1-ecac25308123@suse.de> (raw)
In-Reply-To: <3d2541d7-88b0-1e5b-89c0-13f101f10243@grimberg.me>
On 9/29/20 8:16 PM, Sagi Grimberg wrote:
>
>>> Something here is not clear to me, we are not really talking about "all
>>> paths down" but rather "all paths lost", which should take the gendisk
>>> down AFAIK.
>>>
>>> Keith, shouldn't we modify the gendisk reference manipulation in
>>> nvme_mpath_remove_disk instead of moving it to the call sites?
>>>
>>> I'm still unsure why we need a timer for this. If a path is removed
>>> (e.g. disconnected, we shouldn't keep the gendisk up).
>>
>> True. And I guess the right place to deal with timers is on how long
>> we are going to keep retrying (or at least the underlying disks alive).
>
> Which is orthogonal to this specific patch right?
>
> As for timers, I wouldn't want to introduce a modparam for that. Perhaps
> the correct way to do this is with what Victor suggested where mpath
> fastfail is really the longest controller fastfail...
Yes. If we're talking timers we should be looking a fastfail, as this is
really what we want here.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2020-09-30 5:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 21:38 [RFC] nvme-mpath: delete disk after last connection Keith Busch
2020-09-26 11:16 ` Hannes Reinecke
2020-09-27 6:07 ` Christoph Hellwig
2020-09-28 14:11 ` Keith Busch
2020-09-29 8:28 ` Sagi Grimberg
2020-09-29 18:08 ` Christoph Hellwig
2020-09-29 18:16 ` Sagi Grimberg
2020-09-30 5:36 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bd44c2e-ded8-80b8-e2c1-ecac25308123@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox