From: Minwoo Im <minwoo.im.dev@gmail.com>
To: Chao Leng <lengchao@huawei.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, sagi@grimberg.me,
linux-nvme@lists.infradead.org, axboe@fb.com, kbusch@kernel.org,
hch@lst.de
Subject: Re: [PATCH 1/6] blk-mq: introduce blk_mq_set_request_complete
Date: Wed, 6 Jan 2021 04:16:38 +0900 [thread overview]
Message-ID: <20210105191638.GB4426@localhost.localdomain> (raw)
In-Reply-To: <20210105071936.25097-2-lengchao@huawei.com>
Hello,
On 21-01-05 15:19:31, Chao Leng wrote:
> In some scenarios, nvme need setting the state of request to
> MQ_RQ_COMPLETE. So add an inline function blk_mq_set_request_complete.
> For details, see the subsequent patches.
>
> Signed-off-by: Chao Leng <lengchao@huawei.com>
> ---
> include/linux/blk-mq.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
> index e7482e6ad3ec..cee72d31054d 100644
> --- a/include/linux/blk-mq.h
> +++ b/include/linux/blk-mq.h
> @@ -493,6 +493,11 @@ static inline int blk_mq_request_completed(struct request *rq)
> return blk_mq_rq_state(rq) == MQ_RQ_COMPLETE;
> }
>
> +static inline void blk_mq_set_request_complete(struct request *rq)
> +{
> + WRITE_ONCE(rq->state, MQ_RQ_COMPLETE);
> +}
> +
Maybe we can have this newly added helper with updating caller
in blk_mq_complete_request_remote() also ?
Thanks,
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-05 19:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 7:19 [PATCH 0/6] avoid repeated request completion and IO error Chao Leng
2021-01-05 7:19 ` [PATCH 1/6] blk-mq: introduce blk_mq_set_request_complete Chao Leng
2021-01-05 19:16 ` Minwoo Im [this message]
2021-01-06 2:29 ` Chao Leng
2021-01-05 7:19 ` [PATCH 2/6] nvme-core: introduce complete failed request Chao Leng
2021-01-05 19:11 ` Minwoo Im
2021-01-06 2:31 ` Chao Leng
2021-01-05 7:19 ` [PATCH 3/6] nvme-fabrics: avoid repeated request completion for nvmf_fail_nonready_command Chao Leng
2021-01-05 7:19 ` [PATCH 4/6] nvme-rdma: avoid IO error and repeated request completion Chao Leng
2021-01-05 7:19 ` [PATCH 5/6] nvme-tcp: " Chao Leng
2021-01-05 7:19 ` [PATCH 6/6] nvme-fc: " Chao Leng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210105191638.GB4426@localhost.localdomain \
--to=minwoo.im.dev@gmail.com \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=lengchao@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox