From: Minwoo Im <minwoo.im.dev@gmail.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, Chao Leng <lengchao@huawei.com>
Subject: Re: [PATCH V2 2/2] nvme: retry commands based on ACRE result
Date: Thu, 14 Jan 2021 07:43:16 +0900 [thread overview]
Message-ID: <20210113224316.GA4094@localhost.localdomain> (raw)
In-Reply-To: <3bd35739-c309-b04a-fbd7-90daee5aeae7@grimberg.me>
Hello,
Thanks for your time!
On 21-01-13 14:20:34, Sagi Grimberg wrote:
> > Introduce acre flag for Advanced Command Retry Enable to controller
> > instance to decide whether to retry or not in error cases. This flag is
> > set if Set Features for Host Behavior Support with ACRE bit set is
> > successfully done during reset_work.
> >
> > This patch also fixes nvme_decide_disposition() because all the nvme
> > requests are initialized with REQ_FAILFAST_DRIVER to req->cmd_flags
>
> You mean for passthru commands, nvme doesn't control this for other
> commands.
>
Oh, I forgot to mention... Thanks for catching this.
> > so
> > that blk_noretry_request(req) is always true. Check ctrl->acre first
> > and if it's not host path error, then it will be retried.
>
> I suggest to split out this part to its own patch.
>
Okay. I will split it up to two patches:
- Introducing ACRE flag to controller
- Check ACRE flag in nvme_decide_disposition()
Thanks!
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-13 22:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 14:35 [PATCH V2 0/2] nvme: fixes for command retry Minwoo Im
2021-01-13 14:35 ` [PATCH V2 1/2] nvme: check all retry delay times in Identify Controller Minwoo Im
2021-01-13 14:35 ` [PATCH V2 2/2] nvme: retry commands based on ACRE result Minwoo Im
2021-01-13 22:20 ` Sagi Grimberg
2021-01-13 22:43 ` Minwoo Im [this message]
2021-01-14 2:47 ` Chao Leng
2021-01-14 3:27 ` Minwoo Im
2021-01-14 3:11 ` Keith Busch
2021-01-14 3:28 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113224316.GA4094@localhost.localdomain \
--to=minwoo.im.dev@gmail.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=lengchao@huawei.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox