From: Minwoo Im <minwoo.im.dev@gmail.com>
To: Chao Leng <lengchao@huawei.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH V2 2/2] nvme: retry commands based on ACRE result
Date: Thu, 14 Jan 2021 12:27:21 +0900 [thread overview]
Message-ID: <20210114032721.GA5817@localhost.localdomain> (raw)
In-Reply-To: <b122f482-cb73-67ff-1a30-053c1e8c9c18@huawei.com>
Hello,
> If acre is true and nvme_req(req)->status is nvme path error and
> blk_noretry_request(req) is true, we need return complete for REQ_FAILFAST_XX.
> Otherwise, connection process may takes long time in abnormal scenarios.
> We can do like this:
>
> + if (nvme_req(req)->ctrl->acre &&
> + !nvme_is_path_error(nvme_req(req)->status) &&
> + !blk_queue_dying(req->q))
> + return RETRY;
> +
> + if (blk_noretry_request(req))
> + return COMPLETE;
Ah.. You're right.. I really appreciate for your review!
I will prepare the next patches.
Thank you!
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-14 3:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 14:35 [PATCH V2 0/2] nvme: fixes for command retry Minwoo Im
2021-01-13 14:35 ` [PATCH V2 1/2] nvme: check all retry delay times in Identify Controller Minwoo Im
2021-01-13 14:35 ` [PATCH V2 2/2] nvme: retry commands based on ACRE result Minwoo Im
2021-01-13 22:20 ` Sagi Grimberg
2021-01-13 22:43 ` Minwoo Im
2021-01-14 2:47 ` Chao Leng
2021-01-14 3:27 ` Minwoo Im [this message]
2021-01-14 3:11 ` Keith Busch
2021-01-14 3:28 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114032721.GA5817@localhost.localdomain \
--to=minwoo.im.dev@gmail.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=lengchao@huawei.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox