From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Marc Orr <marcorr@google.com>, Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 2/2] nvme-pci: fix error unwind in nvme_map_data
Date: Wed, 20 Jan 2021 18:56:20 +0100 [thread overview]
Message-ID: <20210120175620.GA26100@lst.de> (raw)
In-Reply-To: <20210120174252.GA27657@redsun51.ssa.fujisawa.hgst.com>
On Thu, Jan 21, 2021 at 02:42:52AM +0900, Keith Busch wrote:
> On Wed, Jan 20, 2021 at 05:48:24PM +0100, Christoph Hellwig wrote:
> > On Wed, Jan 20, 2021 at 07:23:39AM -0800, Marc Orr wrote:
> > > On Wed, Jan 20, 2021 at 1:49 AM Christoph Hellwig <hch@lst.de> wrote:
> > > >
> > > > Properly unwind step by step using refactored helpers from nvme_unmap_data
> > > > to avoid a potential double dma_unmap on a mapping failure.
> > > >
> > > > Reported-by: Marc Orr <marcorr@google.com>
> > > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > >
> > > Should these patches go to stable?
> >
> > Yes. I've added the proper fixes tag:
> >
> > Fixes: 7fe07d14f71f ("nvme-pci: merge nvme_free_iod into nvme_unmap_data")
>
> Patches look good.
>
> Reviewed-by: Keith Busch <kbusch@kernel.org>
>
> Just fyi, the 2/2 is the only one with the "Fixes" tag, but it depends
> on 1/2 to compile. It applies cleanly to the recent stables, though, so
> stable bot might have some trouble with it.
patch 2 obviously depends on 1, the bot has been pretty good at
figuring that out.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2021-01-20 17:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 9:49 fix error unwinding in nvme_map_data Christoph Hellwig
2021-01-20 9:49 ` [PATCH 1/2] nvme-pci: refactor nvme_unmap_data Christoph Hellwig
2021-01-20 15:19 ` Marc Orr
2021-01-20 9:49 ` [PATCH 2/2] nvme-pci: fix error unwind in nvme_map_data Christoph Hellwig
2021-01-20 15:23 ` Marc Orr
2021-01-20 16:48 ` Christoph Hellwig
2021-01-20 17:42 ` Keith Busch
2021-01-20 17:56 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120175620.GA26100@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=marcorr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox