From: Christoph Hellwig <hch@lst.de>
To: Filippo Sironi <sironi@amazon.de>
Cc: sagi@grimberg.me, serebrin@amazon.com,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
axboe@fb.com, kbusch@kernel.org, Christoph Hellwig <hch@lst.de>,
dwmw@amazon.co.uk
Subject: Re: [PATCH] nvme: Add 48-bit DMA address quirk
Date: Wed, 3 Feb 2021 12:15:48 +0100 [thread overview]
Message-ID: <20210203111548.GA11075@lst.de> (raw)
In-Reply-To: <0c38f5eb-41ef-7934-940b-77b6e73c5239@amazon.de>
On Wed, Feb 03, 2021 at 12:12:31PM +0100, Filippo Sironi wrote:
> I don't disagree on the first part of your sentence, this is a big
> oversight.
But it is not what your commit log suggests.
> On the other hand, those controllers are out there and are in use by a lot
> of customers. We can keep relying on luck, hoping that customers don't run
> into troubles or we can merge a few lines of code :)
Your patch does not just quirk a few controllers out there, but all
current and future controllers with an Amazon vendor ID. We could
probably talk about quirking an existing vendor ID or two as long as
this doesn't happen for future hardware.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-02-03 11:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 9:43 [PATCH] nvme: Add 48-bit DMA address quirk Filippo Sironi
2021-02-03 9:51 ` Christoph Hellwig
2021-02-03 11:12 ` Filippo Sironi
2021-02-03 11:15 ` Christoph Hellwig [this message]
2021-02-03 11:22 ` Filippo Sironi
2021-02-03 11:26 ` Christoph Hellwig
2021-02-03 16:57 ` Keith Busch
2021-02-10 0:39 ` [PATCH v2] nvme: Add 48-bit DMA address quirk for Amazon NVMe controllers Filippo Sironi
2021-02-10 7:37 ` Christoph Hellwig
2021-02-10 9:13 ` Filippo Sironi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203111548.GA11075@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=dwmw@amazon.co.uk \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=serebrin@amazon.com \
--cc=sironi@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox