From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@fb.com>
Cc: axboe@kernel.dk, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Chao Leng <lengchao@huawei.com>,
kbusch@kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v5 1/3] blk-mq: introduce blk_mq_set_request_complete
Date: Thu, 4 Feb 2021 16:36:31 +0100 [thread overview]
Message-ID: <20210204153631.GA30261@lst.de> (raw)
In-Reply-To: <70bdb0b1-c7aa-af25-4b28-f8f6675c73ae@fb.com>
On Thu, Feb 04, 2021 at 08:32:17AM -0700, Jens Axboe wrote:
> On 2/4/21 8:30 AM, Christoph Hellwig wrote:
> > On Thu, Feb 04, 2021 at 08:27:46AM -0700, Jens Axboe wrote:
> >> On 1/31/21 8:49 PM, Chao Leng wrote:
> >>> nvme drivers need to set the state of request to MQ_RQ_COMPLETE when
> >>> directly complete request in queue_rq.
> >>> So add blk_mq_set_request_complete.
> >>
> >> This is a bit iffy, but looks ok for the intended use case. We just have
> >> to be careful NOT to add frivolous users of it...
> >
> > Yes, that is my main issue with it. The current use case looks fine,
> > but I suspect every time someone else uses it it's probly going to be
> > as misuse. I've applied this to nvme-5.12 with the rest of the patches,
> > it should be on its way to you soon.
>
> Might benefit from a big fat comment on why you probably shouldn't
> be using it...
I actually reworded the comment a bit, this is the current version:
http://git.infradead.org/nvme.git/commitdiff/bdd2a4a61460a341c1f8462e5caf63195e960623
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-02-04 15:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 3:49 [PATCH v5 0/3] avoid double request completion and IO error Chao Leng
2021-02-01 3:49 ` [PATCH v5 1/3] blk-mq: introduce blk_mq_set_request_complete Chao Leng
2021-02-04 15:27 ` Jens Axboe
2021-02-04 15:30 ` Christoph Hellwig
2021-02-04 15:32 ` Jens Axboe
2021-02-04 15:36 ` Christoph Hellwig [this message]
2021-02-04 15:41 ` Jens Axboe
2021-02-01 3:49 ` [PATCH v5 2/3] nvme-fabrics: avoid double request completion for nvmf_fail_nonready_command Chao Leng
2021-02-01 3:49 ` [PATCH v5 3/3] nvme-rdma: avoid IO error for nvme native multipath Chao Leng
2021-02-03 16:14 ` [PATCH v5 0/3] avoid double request completion and IO error Christoph Hellwig
2021-02-03 22:22 ` Sagi Grimberg
2021-02-04 5:56 ` Chao Leng
2021-02-04 8:04 ` Christoph Hellwig
2021-02-05 2:02 ` Chao Leng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210204153631.GA30261@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=lengchao@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox