From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, damien.lemoal@wdc.com
Subject: Re: [PATCH V13 4/4] nvmet: add req cns error complete helper
Date: Thu, 8 Apr 2021 09:24:36 +0200 [thread overview]
Message-ID: <20210408072436.GC24502@lst.de> (raw)
In-Reply-To: <20210408001427.20501-5-chaitanya.kulkarni@wdc.com>
On Wed, Apr 07, 2021 at 05:14:27PM -0700, Chaitanya Kulkarni wrote:
> We report error and complete the request when identify cns value
> is not handled in nvmet_execute_identify(),
> nvmet_execute_identify_cns_cs_ctrl(), and
> nvmet_execute_identify_cns_cs_ns().
>
> Add a helper nvmet_req_cns_error_compplete() to remove the duplicate
> code from all the above three functions.
Please do this from the beginning instead of fixing up the just
introduced code.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2021-04-08 7:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 0:14 [PATCH V13 0/4] nvmet: add ZBD backend support Chaitanya Kulkarni
2021-04-08 0:14 ` [PATCH V13 1/4] nvmet: add NVM Command Set Identifier support Chaitanya Kulkarni
2021-04-08 7:15 ` Christoph Hellwig
2021-04-08 0:14 ` [PATCH V13 2/4] nvmet: add ZBD over ZNS backend support Chaitanya Kulkarni
2021-04-08 7:23 ` Christoph Hellwig
2021-04-08 21:14 ` Chaitanya Kulkarni
2021-04-09 5:40 ` Christoph Hellwig
2021-04-09 5:42 ` Chaitanya Kulkarni
2021-04-09 7:09 ` Chaitanya Kulkarni
2021-04-09 9:53 ` Christoph Hellwig
2021-04-08 8:01 ` Damien Le Moal
2021-04-08 22:06 ` Chaitanya Kulkarni
2021-04-08 22:33 ` Damien Le Moal
2021-04-08 8:15 ` Damien Le Moal
2021-04-08 0:14 ` [PATCH V13 3/4] nvmet: add nvmet_req_bio put helper for backends Chaitanya Kulkarni
2021-04-08 0:14 ` [PATCH V13 4/4] nvmet: add req cns error complete helper Chaitanya Kulkarni
2021-04-08 7:24 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408072436.GC24502@lst.de \
--to=hch@lst.de \
--cc=chaitanya.kulkarni@wdc.com \
--cc=damien.lemoal@wdc.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox