From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>
Subject: Re: [PATCH V13 2/4] nvmet: add ZBD over ZNS backend support
Date: Fri, 9 Apr 2021 11:53:37 +0200 [thread overview]
Message-ID: <20210409095337.GA16010@lst.de> (raw)
In-Reply-To: <BYAPR04MB496511D1B547762FB9ACABFB86739@BYAPR04MB4965.namprd04.prod.outlook.com>
On Fri, Apr 09, 2021 at 07:09:12AM +0000, Chaitanya Kulkarni wrote:
> diff --git a/drivers/nvme/target/admin-cmd.c
> b/drivers/nvme/target/admin-cmd.c
> index fc5f64a38661..da6d5225f25a 100644
> --- a/drivers/nvme/target/admin-cmd.c
> +++ b/drivers/nvme/target/admin-cmd.c
> @@ -685,6 +685,14 @@ static void nvmet_execute_identify(struct nvmet_req
> *req)
> if (!nvmet_check_transfer_len(req, NVME_IDENTIFY_DATA_SIZE))
> return;
>
> + switch (req->cmd->identify.csi) {
> + case NVME_CSI_NVM:
> + case NVME_CSI_ZNS:
> + break;
> + default:
> + goto out;
> + }
> +
I don't think thi is the right thing to do as only a few CNS values
look at the CSI, so we'd need this switch in those switch cases that
need CNS values only.
The rest looks good.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-09 9:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 0:14 [PATCH V13 0/4] nvmet: add ZBD backend support Chaitanya Kulkarni
2021-04-08 0:14 ` [PATCH V13 1/4] nvmet: add NVM Command Set Identifier support Chaitanya Kulkarni
2021-04-08 7:15 ` Christoph Hellwig
2021-04-08 0:14 ` [PATCH V13 2/4] nvmet: add ZBD over ZNS backend support Chaitanya Kulkarni
2021-04-08 7:23 ` Christoph Hellwig
2021-04-08 21:14 ` Chaitanya Kulkarni
2021-04-09 5:40 ` Christoph Hellwig
2021-04-09 5:42 ` Chaitanya Kulkarni
2021-04-09 7:09 ` Chaitanya Kulkarni
2021-04-09 9:53 ` Christoph Hellwig [this message]
2021-04-08 8:01 ` Damien Le Moal
2021-04-08 22:06 ` Chaitanya Kulkarni
2021-04-08 22:33 ` Damien Le Moal
2021-04-08 8:15 ` Damien Le Moal
2021-04-08 0:14 ` [PATCH V13 3/4] nvmet: add nvmet_req_bio put helper for backends Chaitanya Kulkarni
2021-04-08 0:14 ` [PATCH V13 4/4] nvmet: add req cns error complete helper Chaitanya Kulkarni
2021-04-08 7:24 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210409095337.GA16010@lst.de \
--to=hch@lst.de \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox