* Re: [PATCH] nvme-tcp: remove incorrect Kconfig dep in BLK_DEV_NVME
2021-05-21 21:51 [PATCH] nvme-tcp: remove incorrect Kconfig dep in BLK_DEV_NVME Sagi Grimberg
@ 2021-05-21 22:36 ` Chaitanya Kulkarni
2021-05-24 14:36 ` Max Gurtovoy
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Chaitanya Kulkarni @ 2021-05-21 22:36 UTC (permalink / raw)
To: Sagi Grimberg, linux-nvme@lists.infradead.org, Christoph Hellwig,
Keith Busch
On 5/21/21 14:59, Sagi Grimberg wrote:
> We need to select NVME_CORE.
>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] nvme-tcp: remove incorrect Kconfig dep in BLK_DEV_NVME
2021-05-21 21:51 [PATCH] nvme-tcp: remove incorrect Kconfig dep in BLK_DEV_NVME Sagi Grimberg
2021-05-21 22:36 ` Chaitanya Kulkarni
@ 2021-05-24 14:36 ` Max Gurtovoy
2021-05-24 15:18 ` Keith Busch
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Max Gurtovoy @ 2021-05-24 14:36 UTC (permalink / raw)
To: Sagi Grimberg, linux-nvme, Christoph Hellwig, Keith Busch
On 5/22/2021 12:51 AM, Sagi Grimberg wrote:
> We need to select NVME_CORE.
>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> ---
> drivers/nvme/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
> index a44d49d63968..c0826b3c617c 100644
> --- a/drivers/nvme/host/Kconfig
> +++ b/drivers/nvme/host/Kconfig
> @@ -71,7 +71,7 @@ config NVME_FC
> config NVME_TCP
> tristate "NVM Express over Fabrics TCP host driver"
> depends on INET
> - depends on BLK_DEV_NVME
> + select NVME_CORE
> select NVME_FABRICS
> select CRYPTO
> select CRYPTO_CRC32C
Looks good,
Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] nvme-tcp: remove incorrect Kconfig dep in BLK_DEV_NVME
2021-05-21 21:51 [PATCH] nvme-tcp: remove incorrect Kconfig dep in BLK_DEV_NVME Sagi Grimberg
2021-05-21 22:36 ` Chaitanya Kulkarni
2021-05-24 14:36 ` Max Gurtovoy
@ 2021-05-24 15:18 ` Keith Busch
2021-05-25 7:25 ` Christoph Hellwig
2021-05-26 14:19 ` Christoph Hellwig
4 siblings, 0 replies; 6+ messages in thread
From: Keith Busch @ 2021-05-24 15:18 UTC (permalink / raw)
To: Sagi Grimberg; +Cc: linux-nvme, Christoph Hellwig
On Fri, May 21, 2021 at 02:51:15PM -0700, Sagi Grimberg wrote:
> We need to select NVME_CORE.
This looks fine and matches what the other drivers are doing, but I
think a more appropriate dependency should have NVME_FABRICS select
NVME_CORE.
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> ---
> drivers/nvme/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
> index a44d49d63968..c0826b3c617c 100644
> --- a/drivers/nvme/host/Kconfig
> +++ b/drivers/nvme/host/Kconfig
> @@ -71,7 +71,7 @@ config NVME_FC
> config NVME_TCP
> tristate "NVM Express over Fabrics TCP host driver"
> depends on INET
> - depends on BLK_DEV_NVME
> + select NVME_CORE
> select NVME_FABRICS
> select CRYPTO
> select CRYPTO_CRC32C
> --
> 2.27.0
>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nvme-tcp: remove incorrect Kconfig dep in BLK_DEV_NVME
2021-05-21 21:51 [PATCH] nvme-tcp: remove incorrect Kconfig dep in BLK_DEV_NVME Sagi Grimberg
` (2 preceding siblings ...)
2021-05-24 15:18 ` Keith Busch
@ 2021-05-25 7:25 ` Christoph Hellwig
2021-05-26 14:19 ` Christoph Hellwig
4 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2021-05-25 7:25 UTC (permalink / raw)
To: Sagi Grimberg; +Cc: linux-nvme, Christoph Hellwig, Keith Busch
The transitive select sounds nice, but I've applied to trivial fix to
nvme-5.13 for now.
Thanks!
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] nvme-tcp: remove incorrect Kconfig dep in BLK_DEV_NVME
2021-05-21 21:51 [PATCH] nvme-tcp: remove incorrect Kconfig dep in BLK_DEV_NVME Sagi Grimberg
` (3 preceding siblings ...)
2021-05-25 7:25 ` Christoph Hellwig
@ 2021-05-26 14:19 ` Christoph Hellwig
4 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2021-05-26 14:19 UTC (permalink / raw)
To: Sagi Grimberg; +Cc: linux-nvme, Christoph Hellwig, Keith Busch
With this we lost the required dependency on CONFIG_BLOCK. I've folded
a line in to add it back.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 6+ messages in thread