From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@wdc.com>,
linux-nvme@lists.infradead.org, Hannes Reinecke <hare@suse.de>,
Daniel Wagner <daniel.wagner@suse.de>
Subject: [PATCH] nvme: rename 'subtype' attribute to 'subsystype'
Date: Thu, 14 Oct 2021 11:27:34 +0200 [thread overview]
Message-ID: <20211014092734.138079-1-hare@suse.de> (raw)
The sysfs attribute should be named 'subsystype' for consistency.
Fixes: b72529169a56 ("nvme: expose subsystem type in sysfs attribute 'subtype'")
Suggested-by: Daniel Wagner <daniel.wagner@suse.de>
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/nvme/host/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index f9a25c61fb8b..4d676b5db413 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2599,7 +2599,7 @@ static ssize_t nvme_subsys_show_nqn(struct device *dev,
}
static SUBSYS_ATTR_RO(subsysnqn, S_IRUGO, nvme_subsys_show_nqn);
-static ssize_t nvme_subsys_show_subtype(struct device *dev,
+static ssize_t nvme_subsys_show_type(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -2615,7 +2615,7 @@ static ssize_t nvme_subsys_show_subtype(struct device *dev,
return sysfs_emit(buf, "reserved\n");
}
}
-static SUBSYS_ATTR_RO(subtype, S_IRUGO, nvme_subsys_show_subtype);
+static SUBSYS_ATTR_RO(subsystype, S_IRUGO, nvme_subsys_show_type);
#define nvme_subsys_show_str_function(field) \
static ssize_t subsys_##field##_show(struct device *dev, \
@@ -2637,7 +2637,7 @@ static struct attribute *nvme_subsys_attrs[] = {
&subsys_attr_serial.attr,
&subsys_attr_firmware_rev.attr,
&subsys_attr_subsysnqn.attr,
- &subsys_attr_subtype.attr,
+ &subsys_attr_subsystype.attr,
#ifdef CONFIG_NVME_MULTIPATH
&subsys_attr_iopolicy.attr,
#endif
--
2.29.2
next reply other threads:[~2021-10-14 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 9:27 Hannes Reinecke [this message]
2021-10-14 11:34 ` [PATCH] nvme: rename 'subtype' attribute to 'subsystype' Daniel Wagner
2021-10-16 4:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014092734.138079-1-hare@suse.de \
--to=hare@suse.de \
--cc=daniel.wagner@suse.de \
--cc=hch@lst.de \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox