* [PATCH] nvme: rename 'subtype' attribute to 'subsystype'
@ 2021-10-14 9:27 Hannes Reinecke
2021-10-14 11:34 ` Daniel Wagner
2021-10-16 4:39 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Hannes Reinecke @ 2021-10-14 9:27 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Sagi Grimberg, Keith Busch, linux-nvme, Hannes Reinecke,
Daniel Wagner
The sysfs attribute should be named 'subsystype' for consistency.
Fixes: b72529169a56 ("nvme: expose subsystem type in sysfs attribute 'subtype'")
Suggested-by: Daniel Wagner <daniel.wagner@suse.de>
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/nvme/host/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index f9a25c61fb8b..4d676b5db413 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2599,7 +2599,7 @@ static ssize_t nvme_subsys_show_nqn(struct device *dev,
}
static SUBSYS_ATTR_RO(subsysnqn, S_IRUGO, nvme_subsys_show_nqn);
-static ssize_t nvme_subsys_show_subtype(struct device *dev,
+static ssize_t nvme_subsys_show_type(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -2615,7 +2615,7 @@ static ssize_t nvme_subsys_show_subtype(struct device *dev,
return sysfs_emit(buf, "reserved\n");
}
}
-static SUBSYS_ATTR_RO(subtype, S_IRUGO, nvme_subsys_show_subtype);
+static SUBSYS_ATTR_RO(subsystype, S_IRUGO, nvme_subsys_show_type);
#define nvme_subsys_show_str_function(field) \
static ssize_t subsys_##field##_show(struct device *dev, \
@@ -2637,7 +2637,7 @@ static struct attribute *nvme_subsys_attrs[] = {
&subsys_attr_serial.attr,
&subsys_attr_firmware_rev.attr,
&subsys_attr_subsysnqn.attr,
- &subsys_attr_subtype.attr,
+ &subsys_attr_subsystype.attr,
#ifdef CONFIG_NVME_MULTIPATH
&subsys_attr_iopolicy.attr,
#endif
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme: rename 'subtype' attribute to 'subsystype'
2021-10-14 9:27 [PATCH] nvme: rename 'subtype' attribute to 'subsystype' Hannes Reinecke
@ 2021-10-14 11:34 ` Daniel Wagner
2021-10-16 4:39 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Wagner @ 2021-10-14 11:34 UTC (permalink / raw)
To: Hannes Reinecke
Cc: Christoph Hellwig, Sagi Grimberg, Keith Busch, linux-nvme,
Daniel Wagner
On Thu, Oct 14, 2021 at 11:27:34AM +0200, Hannes Reinecke wrote:
> The sysfs attribute should be named 'subsystype' for consistency.
>
> Fixes: b72529169a56 ("nvme: expose subsystem type in sysfs attribute 'subtype'")
> Suggested-by: Daniel Wagner <daniel.wagner@suse.de>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
LGTM,
Reviewed-by: Daniel Wagner <dwagner@suse.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme: rename 'subtype' attribute to 'subsystype'
2021-10-14 9:27 [PATCH] nvme: rename 'subtype' attribute to 'subsystype' Hannes Reinecke
2021-10-14 11:34 ` Daniel Wagner
@ 2021-10-16 4:39 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2021-10-16 4:39 UTC (permalink / raw)
To: Hannes Reinecke
Cc: Christoph Hellwig, Sagi Grimberg, Keith Busch, linux-nvme,
Daniel Wagner
Thanks,
folded into the original patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-16 4:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-14 9:27 [PATCH] nvme: rename 'subtype' attribute to 'subsystype' Hannes Reinecke
2021-10-14 11:34 ` Daniel Wagner
2021-10-16 4:39 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox