From: Christoph Hellwig <hch@lst.de>
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, sagi@grimberg.me,
chaitanyak@nvidia.com, oren@nvidia.com, benishay@nvidia.com,
borisp@nvidia.com, aviadye@nvidia.com, idanb@nvidia.com,
jsmart2021@gmail.com
Subject: Re: [PATCH v1 0/4] Add command id quirk for fabrics
Date: Tue, 9 Nov 2021 15:31:02 +0100 [thread overview]
Message-ID: <20211109143102.GA25263@lst.de> (raw)
In-Reply-To: <9c740227-8c98-5877-9a9a-ae17756e851c@nvidia.com>
On Tue, Nov 09, 2021 at 04:23:33PM +0200, Max Gurtovoy wrote:
> On 11/9/2021 3:15 PM, Christoph Hellwig wrote:
>> Max, if you can't point us to a broken target (and yes, it is broken)
>> this will not go anywhere.
>
> Any target that uses Apple device as backend can be harmed.
>
> Most simple example is Linux PT target that copy the sqe as-is and passes
> it to the NVMe Apple drive.
Take another close look at how command_id are assigned my Linux driver.
We obviously do not pass it through as that would be completely broken.
next prev parent reply other threads:[~2021-11-09 14:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 14:46 [PATCH v1 0/4] Add command id quirk for fabrics Max Gurtovoy
2021-11-08 14:46 ` [PATCH 1/1 nvmecli] fabrics: add new --skip-cid-gen flag to connect cmd Max Gurtovoy
2021-11-08 14:46 ` [PATCH 1/1 libnvme] fabrics: add support for new cli --skip-cid-gen flag Max Gurtovoy
2021-11-08 14:47 ` [PATCH 1/4] nvme-fabrics: add command id quirk for fabrics controllers Max Gurtovoy
2021-11-08 14:47 ` [PATCH 2/4] nvme-rdma: add command id quirk for RDMA controllers Max Gurtovoy
2021-11-08 14:47 ` [PATCH 3/4] nvme-tcp: add command id quirk for TCP controllers Max Gurtovoy
2021-11-08 14:47 ` [PATCH 4/4] nvme-fc: add command id quirk for FC controllers Max Gurtovoy
2021-11-08 16:45 ` [PATCH v1 0/4] Add command id quirk for fabrics Keith Busch
2021-11-09 8:09 ` Christoph Hellwig
2021-11-09 12:08 ` Max Gurtovoy
2021-11-09 13:15 ` Christoph Hellwig
2021-11-09 14:23 ` Max Gurtovoy
2021-11-09 14:31 ` Christoph Hellwig [this message]
2021-11-09 16:15 ` Keith Busch
2021-11-09 16:59 ` Max Gurtovoy
2021-11-09 19:04 ` Keith Busch
2021-11-10 19:45 ` Sagi Grimberg
2021-11-11 9:29 ` Max Gurtovoy
2021-11-11 17:36 ` Keith Busch
2021-11-12 16:07 ` Sagi Grimberg
2021-11-12 21:37 ` Keith Busch
2021-11-18 11:19 ` Max Gurtovoy
2021-11-21 10:05 ` Sagi Grimberg
2021-11-10 10:32 ` Daniel Wagner
2021-11-10 10:56 ` Max Gurtovoy
2021-11-10 11:18 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211109143102.GA25263@lst.de \
--to=hch@lst.de \
--cc=aviadye@nvidia.com \
--cc=benishay@nvidia.com \
--cc=borisp@nvidia.com \
--cc=chaitanyak@nvidia.com \
--cc=idanb@nvidia.com \
--cc=jsmart2021@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=oren@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox