From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
<linux-nvme@lists.infradead.org>, <sagi@grimberg.me>,
<chaitanyak@nvidia.com>, <oren@nvidia.com>, <benishay@nvidia.com>,
<borisp@nvidia.com>, <aviadye@nvidia.com>, <idanb@nvidia.com>,
<jsmart2021@gmail.com>
Subject: Re: [PATCH v1 0/4] Add command id quirk for fabrics
Date: Wed, 10 Nov 2021 12:56:38 +0200 [thread overview]
Message-ID: <917d7535-9749-2738-6162-4d2d390e478c@nvidia.com> (raw)
In-Reply-To: <20211110103247.i7jnkg3bpbet42wm@carbon.lan>
On 11/10/2021 12:32 PM, Daniel Wagner wrote:
> On Tue, Nov 09, 2021 at 02:08:27PM +0200, Max Gurtovoy wrote:
>> We also don't know the target that cause the bug in the initial genctr
>> commit..
> As I was the one asking for this feature: During development phase we
> saw invalid cmd_id from a (buggy) target. The target has been fixed. It
> never got released to the public.
I see.
It's strange that we need to add all these if conditions and logic in
the fast path for RDMA/PCI/FC and even for TCP for some non existing
target that was buggy in the development process.
And all of this is the default behavior for all transports.
next prev parent reply other threads:[~2021-11-10 10:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 14:46 [PATCH v1 0/4] Add command id quirk for fabrics Max Gurtovoy
2021-11-08 14:46 ` [PATCH 1/1 nvmecli] fabrics: add new --skip-cid-gen flag to connect cmd Max Gurtovoy
2021-11-08 14:46 ` [PATCH 1/1 libnvme] fabrics: add support for new cli --skip-cid-gen flag Max Gurtovoy
2021-11-08 14:47 ` [PATCH 1/4] nvme-fabrics: add command id quirk for fabrics controllers Max Gurtovoy
2021-11-08 14:47 ` [PATCH 2/4] nvme-rdma: add command id quirk for RDMA controllers Max Gurtovoy
2021-11-08 14:47 ` [PATCH 3/4] nvme-tcp: add command id quirk for TCP controllers Max Gurtovoy
2021-11-08 14:47 ` [PATCH 4/4] nvme-fc: add command id quirk for FC controllers Max Gurtovoy
2021-11-08 16:45 ` [PATCH v1 0/4] Add command id quirk for fabrics Keith Busch
2021-11-09 8:09 ` Christoph Hellwig
2021-11-09 12:08 ` Max Gurtovoy
2021-11-09 13:15 ` Christoph Hellwig
2021-11-09 14:23 ` Max Gurtovoy
2021-11-09 14:31 ` Christoph Hellwig
2021-11-09 16:15 ` Keith Busch
2021-11-09 16:59 ` Max Gurtovoy
2021-11-09 19:04 ` Keith Busch
2021-11-10 19:45 ` Sagi Grimberg
2021-11-11 9:29 ` Max Gurtovoy
2021-11-11 17:36 ` Keith Busch
2021-11-12 16:07 ` Sagi Grimberg
2021-11-12 21:37 ` Keith Busch
2021-11-18 11:19 ` Max Gurtovoy
2021-11-21 10:05 ` Sagi Grimberg
2021-11-10 10:32 ` Daniel Wagner
2021-11-10 10:56 ` Max Gurtovoy [this message]
2021-11-10 11:18 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=917d7535-9749-2738-6162-4d2d390e478c@nvidia.com \
--to=mgurtovoy@nvidia.com \
--cc=aviadye@nvidia.com \
--cc=benishay@nvidia.com \
--cc=borisp@nvidia.com \
--cc=chaitanyak@nvidia.com \
--cc=dwagner@suse.de \
--cc=hch@lst.de \
--cc=idanb@nvidia.com \
--cc=jsmart2021@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=oren@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox