From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-nvme@lists.infradead.org, hch@lst.de,
Max Gurtovoy <mgurtovoy@nvidia.com>,
Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH] nvme: disable namespaces with unsupported metadata
Date: Wed, 24 Nov 2021 19:47:57 +0100 [thread overview]
Message-ID: <20211124184757.GA22791@lst.de> (raw)
In-Reply-To: <20211123174554.3574990-1-kbusch@kernel.org>
On Tue, Nov 23, 2021 at 09:45:54AM -0800, Keith Busch wrote:
> The only fabrics target that supports metadata is RDMA and usable only
> if it is 8B per block, and formatted for protection information. If an
> rdma target were to export a namespace with a different format (ex:
> 4k+64B), the driver will not be able to submit a valid command for that
> format.
>
> Suppress exporting these namespaces as read/writeable to the block
> stack.
Where do we disable the namepsace? We only do not set the metadata
supported flag here, don't we?
> + /*
> + * Currently rdma is the only fabrics nvme host that supports
> + * metadata integrity segments, but will not use the metadata
> + * payload if it doesn't satisfy 'nvme_ns_has_pi()'.
s/fabric nvme host/transport/
> Since the
> + * initiator is not able to form requests that satisify the
> + * format, do not support the namespace if the metadata does
> + * not satisfy that requirement.
> + */
I can't really parse this sentence. Also initiator doesn't make much
sense in a NVMe context.
next prev parent reply other threads:[~2021-11-24 18:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 17:45 [PATCH] nvme: disable namespaces with unsupported metadata Keith Busch
2021-11-23 19:59 ` Sagi Grimberg
2021-11-23 21:10 ` Keith Busch
2021-11-24 9:29 ` Max Gurtovoy
2021-11-24 18:47 ` Christoph Hellwig [this message]
2021-11-24 19:57 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211124184757.GA22791@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox