From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: Keith Busch <kbusch@kernel.org>, <linux-nvme@lists.infradead.org>,
<hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH] nvme: disable namespaces with unsupported metadata
Date: Wed, 24 Nov 2021 11:29:18 +0200 [thread overview]
Message-ID: <493d597c-e38e-db9f-aed3-11e64bcb1321@nvidia.com> (raw)
In-Reply-To: <20211123211029.GE3540867@dhcp-10-100-145-180.wdc.com>
On 11/23/2021 11:10 PM, Keith Busch wrote:
> On Tue, Nov 23, 2021 at 09:45:54AM -0800, Keith Busch wrote:
>> The only fabrics target that supports metadata is RDMA and usable only
> Sorry, the above should have said:
>
> "The only fabrics host driver that currently supports metadata is ..."
>
> I believe the spec allows all transports to support any arbitrary
> metadata format. The drivers just currently aren't able to, and we can
> update this path as they become more capable.
>
>> if it is 8B per block, and formatted for protection information. If an
>> rdma target were to export a namespace with a different format (ex:
>> 4k+64B), the driver will not be able to submit a valid command for that
>> format.
>>
>> Suppress exporting these namespaces as read/writeable to the block
>> stack.
Looks good,
Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>
next prev parent reply other threads:[~2021-11-24 9:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 17:45 [PATCH] nvme: disable namespaces with unsupported metadata Keith Busch
2021-11-23 19:59 ` Sagi Grimberg
2021-11-23 21:10 ` Keith Busch
2021-11-24 9:29 ` Max Gurtovoy [this message]
2021-11-24 18:47 ` Christoph Hellwig
2021-11-24 19:57 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493d597c-e38e-db9f-aed3-11e64bcb1321@nvidia.com \
--to=mgurtovoy@nvidia.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox