From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: <kbusch@kernel.org>, <hch@lst.de>, <sagi@grimberg.me>
Cc: <linux-nvme@lists.infradead.org>, Chaitanya Kulkarni <kch@nvidia.com>
Subject: [PATCH 3/3] nvme: add KConfig options for debug features
Date: Fri, 10 Dec 2021 03:21:16 -0800 [thread overview]
Message-ID: <20211210112116.9299-4-chaitanyak@nvidia.com> (raw)
In-Reply-To: <20211210112116.9299-1-chaitanyak@nvidia.com>
From: Chaitanya Kulkarni <kch@nvidia.com>
Add KConfig menu option to enable and disable gencounter debug
feature that uses config NVME_DEBUG_USE_CID_GENCTR.
Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
---
drivers/nvme/host/Kconfig | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
index dc0450ca23a3..dfa2609b7006 100644
--- a/drivers/nvme/host/Kconfig
+++ b/drivers/nvme/host/Kconfig
@@ -1,4 +1,14 @@
# SPDX-License-Identifier: GPL-2.0-only
+menu "Debug (Enable driver debug features)"
+config NVME_DEBUG_USE_CID_GENCTR
+ bool "Enable command ID gen counter for spurious request completion"
+ depends on NVME_CORE
+ help
+ The NVM Express driver will use generation conunter
+ when calculating the command id. This is needed to debug the
+ spurious request completions coming from a buggy controller.
+endmenu
+
config NVME_CORE
tristate
select BLK_DEV_INTEGRITY_T10 if BLK_DEV_INTEGRITY
--
2.29.0
next prev parent reply other threads:[~2021-12-10 11:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 11:21 [PATCH 0/3] nvme-core: make gencounter feature tunable Chaitanya Kulkarni
2021-12-10 11:21 ` [PATCH 1/3] nvme-core: make cid gencounter configurable Chaitanya Kulkarni
2021-12-10 11:21 ` [PATCH 2/3] nvme-core: move gencounter check into nvme_cid() Chaitanya Kulkarni
2021-12-10 15:43 ` Keith Busch
2021-12-10 17:46 ` Chaitanya Kulkarni
2021-12-12 9:19 ` Sagi Grimberg
2021-12-13 7:07 ` Chaitanya Kulkarni
2021-12-10 11:21 ` Chaitanya Kulkarni [this message]
2021-12-12 9:22 ` [PATCH 3/3] nvme: add KConfig options for debug features Sagi Grimberg
2021-12-13 7:39 ` Chaitanya Kulkarni
2021-12-13 9:27 ` Sagi Grimberg
2021-12-14 7:54 ` Chaitanya Kulkarni
2021-12-14 11:03 ` Sagi Grimberg
2021-12-17 6:52 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211210112116.9299-4-chaitanyak@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox