From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"hch@lst.de" <hch@lst.de>,
"kbusch@kernel.org" <kbusch@kernel.org>
Subject: Re: [PATCH 3/3] nvme: add KConfig options for debug features
Date: Fri, 17 Dec 2021 06:52:33 +0000 [thread overview]
Message-ID: <41fef62e-8e48-d286-8156-c4745f767370@nvidia.com> (raw)
In-Reply-To: <916e5eeb-8cda-b369-f216-6f7edefebb7e@grimberg.me>
>>>> A controller(s) that is used in the production environment goes
>>>> through qualification process from vendors and from the consumers
>>>> to make sure they are stable, something like spurious completions
>>>> detection is a basic part of the qualification,
>>>
>>> I don't think that assuming that a production controller does not
>>> have any hidden bugs is a great practice, and controllers evolve during
>>> their production lifetime.
>>>
>>
>> That is why we should keep it configurable and let user decide.
>
> OK, so this allows a user that is absolutely set on shaving few
> nano-seconds to sacrifice a level of protection against buggy
> controllers. Is this a real use-case?
>
> For that, I guess the config option is fine, but this at the very least
> needs to default to y.
Okay, I'll send out V2 with default options set to y.
prev parent reply other threads:[~2021-12-17 6:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 11:21 [PATCH 0/3] nvme-core: make gencounter feature tunable Chaitanya Kulkarni
2021-12-10 11:21 ` [PATCH 1/3] nvme-core: make cid gencounter configurable Chaitanya Kulkarni
2021-12-10 11:21 ` [PATCH 2/3] nvme-core: move gencounter check into nvme_cid() Chaitanya Kulkarni
2021-12-10 15:43 ` Keith Busch
2021-12-10 17:46 ` Chaitanya Kulkarni
2021-12-12 9:19 ` Sagi Grimberg
2021-12-13 7:07 ` Chaitanya Kulkarni
2021-12-10 11:21 ` [PATCH 3/3] nvme: add KConfig options for debug features Chaitanya Kulkarni
2021-12-12 9:22 ` Sagi Grimberg
2021-12-13 7:39 ` Chaitanya Kulkarni
2021-12-13 9:27 ` Sagi Grimberg
2021-12-14 7:54 ` Chaitanya Kulkarni
2021-12-14 11:03 ` Sagi Grimberg
2021-12-17 6:52 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41fef62e-8e48-d286-8156-c4745f767370@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox