From: Christoph Hellwig <hch@lst.de>
To: John Meneghini <jmeneghi@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@wdc.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-multipath: add an 'ana_groups_only' module option
Date: Thu, 10 Feb 2022 06:43:23 +0100 [thread overview]
Message-ID: <20220210054323.GA3293@lst.de> (raw)
In-Reply-To: <56fb153a-ba0e-605b-e774-885c259965a6@redhat.com>
On Wed, Feb 09, 2022 at 09:52:45PM -0500, John Meneghini wrote:
> I agree with Christoph. I don't see the point in supporting 65536
> namespaces across 49 ana groups or controllers. The problem here is: the
> vendor is trying to turn NVMe into SCSI.
I'm not saying we should not support it. We can trivially do that by
using a vmalloc buffer. I don't think we should optimize for it, and
we certainly should not break behaviour which I think this does.
>
> Moreover, I don't understand how implementing this as a MODULE_PARM is
> supposed to work. If you configure this module parameter on it assumes all
> NVMe-oF arrays connected to the host support RGO. What's really needed here
> is some kind of protocol mechanism that will allow the host to dynamically
> discovery if RGO is supported on a controller by controller basis.
RGO support is mandatory and has been there since the first released
ANA TP.
next prev parent reply other threads:[~2022-02-10 5:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 10:00 [PATCH] nvme-multipath: add an 'ana_groups_only' module option Hannes Reinecke
2022-02-07 12:37 ` Sagi Grimberg
2022-02-07 13:00 ` Hannes Reinecke
2022-02-09 8:07 ` Christoph Hellwig
2022-02-09 8:49 ` Hannes Reinecke
2022-02-09 13:57 ` Christoph Hellwig
2022-02-10 2:52 ` John Meneghini
2022-02-10 5:43 ` Christoph Hellwig [this message]
2022-02-10 8:17 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220210054323.GA3293@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=jmeneghi@redhat.com \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox