* [PATCH] nvme-multipath: call bio_io_error in nvme_ns_head_submit_bio
@ 2022-03-09 6:02 Guoqing Jiang
2022-03-09 16:11 ` Chaitanya Kulkarni
2022-03-09 18:28 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Guoqing Jiang @ 2022-03-09 6:02 UTC (permalink / raw)
To: kbusch, axboe, hch, sagi; +Cc: linux-nvme
Use bio_io_error() here since bio_io_error does the same thing.
Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
---
drivers/nvme/host/multipath.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
index f8bf6606eb2f..31c756fffcec 100644
--- a/drivers/nvme/host/multipath.c
+++ b/drivers/nvme/host/multipath.c
@@ -386,8 +386,7 @@ static void nvme_ns_head_submit_bio(struct bio *bio)
} else {
dev_warn_ratelimited(dev, "no available path - failing I/O\n");
- bio->bi_status = BLK_STS_IOERR;
- bio_endio(bio);
+ bio_io_error(bio);
}
srcu_read_unlock(&head->srcu, srcu_idx);
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-multipath: call bio_io_error in nvme_ns_head_submit_bio
2022-03-09 6:02 [PATCH] nvme-multipath: call bio_io_error in nvme_ns_head_submit_bio Guoqing Jiang
@ 2022-03-09 16:11 ` Chaitanya Kulkarni
2022-03-09 18:28 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2022-03-09 16:11 UTC (permalink / raw)
To: Guoqing Jiang, kbusch@kernel.org, axboe@fb.com, hch@lst.de,
sagi@grimberg.me
Cc: linux-nvme@lists.infradead.org
On 3/8/22 22:02, Guoqing Jiang wrote:
> Use bio_io_error() here since bio_io_error does the same thing.
>
> Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-multipath: call bio_io_error in nvme_ns_head_submit_bio
2022-03-09 6:02 [PATCH] nvme-multipath: call bio_io_error in nvme_ns_head_submit_bio Guoqing Jiang
2022-03-09 16:11 ` Chaitanya Kulkarni
@ 2022-03-09 18:28 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2022-03-09 18:28 UTC (permalink / raw)
To: Guoqing Jiang; +Cc: kbusch, axboe, hch, sagi, linux-nvme
Thanks,
applied to nvme-5.18.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-09 18:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-09 6:02 [PATCH] nvme-multipath: call bio_io_error in nvme_ns_head_submit_bio Guoqing Jiang
2022-03-09 16:11 ` Chaitanya Kulkarni
2022-03-09 18:28 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox