From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org
Cc: Yi Zhang <yi.zhang@redhat.com>,
Chunguang Xu <brookxu.cn@gmail.com>,
Ming Lei <ming.lei@redhat.com>
Subject: [PATCH 3/6] nvme: tcp: unquiesce queues after ctrl state is changed
Date: Mon, 10 Jul 2023 23:35:52 +0800 [thread overview]
Message-ID: <20230710153555.1766438-4-ming.lei@redhat.com> (raw)
In-Reply-To: <20230710153555.1766438-1-ming.lei@redhat.com>
Unquiesce queues until controller state is changed successfully.
Prepare for moving start freeze into reconnect work for preventing new
request from entering queue in LIVE state.
Before removing namespace, unquiescing queues is done unconditionally, so
it is safe to do this way in case of state change failure.
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
drivers/nvme/host/tcp.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index e414cfb3433f..e68bf21af348 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c
@@ -2109,10 +2109,7 @@ static void nvme_tcp_error_recovery_work(struct work_struct *work)
nvme_stop_keep_alive(ctrl);
flush_work(&ctrl->async_event_work);
nvme_tcp_teardown_io_queues(ctrl);
- /* unquiesce to fail fast pending requests */
- nvme_unquiesce_io_queues(ctrl);
nvme_tcp_teardown_admin_queue(ctrl);
- nvme_unquiesce_admin_queue(ctrl);
nvme_auth_stop(ctrl);
if (!nvme_change_ctrl_state(ctrl, NVME_CTRL_CONNECTING)) {
@@ -2122,6 +2119,10 @@ static void nvme_tcp_error_recovery_work(struct work_struct *work)
return;
}
+ /* unquiesce to fail fast pending requests */
+ nvme_unquiesce_io_queues(ctrl);
+ nvme_unquiesce_admin_queue(ctrl);
+
nvme_tcp_reconnect_or_remove(ctrl);
}
--
2.40.1
next prev parent reply other threads:[~2023-07-10 15:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 15:35 [PATCH 0/6] nvme fabircs: move start freeze into reconnection work Ming Lei
2023-07-10 15:35 ` [PATCH 1/6] nvme: unquiesce io queues when removing namespaces Ming Lei
2023-07-10 15:37 ` Keith Busch
2023-07-11 7:32 ` Sagi Grimberg
2023-07-11 8:27 ` Christoph Hellwig
2023-07-11 8:31 ` Ming Lei
2023-07-11 9:12 ` Sagi Grimberg
2023-07-10 15:35 ` [PATCH 2/6] nvme: tcp: remove 'shutdown' parameters from two teardown helpers Ming Lei
2023-07-11 7:38 ` Sagi Grimberg
2023-07-11 7:39 ` Sagi Grimberg
2023-07-10 15:35 ` Ming Lei [this message]
2023-07-11 7:41 ` [PATCH 3/6] nvme: tcp: unquiesce queues after ctrl state is changed Sagi Grimberg
2023-07-11 7:53 ` Ming Lei
2023-07-11 9:05 ` Sagi Grimberg
2023-07-10 15:35 ` [PATCH 4/6] nvme: rdma: unquiesce queues until " Ming Lei
2023-07-11 7:42 ` Sagi Grimberg
2023-07-10 15:35 ` [PATCH 5/6] nvem: tcp: move start freeze into nvme_tcp_configure_io_queues Ming Lei
2023-07-11 7:36 ` Sagi Grimberg
2023-07-10 15:35 ` [PATCH 6/6] nvem: rdma: move start freeze into nvme_rdma_configure_io_queues Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230710153555.1766438-4-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=brookxu.cn@gmail.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox