* [PATCH] nvme-pci: fix DMA direction of unmapping integrity data
@ 2023-07-13 9:26 Ming Lei
2023-07-13 11:37 ` Christoph Hellwig
2023-07-13 15:19 ` Keith Busch
0 siblings, 2 replies; 3+ messages in thread
From: Ming Lei @ 2023-07-13 9:26 UTC (permalink / raw)
To: Christoph Hellwig, Keith Busch, linux-nvme; +Cc: Ming Lei, Guangwu Zhang
DMA direction should be taken in dma_unmap_page() for unmapping integrity
data.
Fix this DMA direction, and reported in Guangwu's test.
Reported-by: Guangwu Zhang <guazhang@redhat.com>
Fixes: 4aedb705437f ("nvme-pci: split metadata handling from nvme_map_data / nvme_unmap_data")
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
drivers/nvme/host/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index cb13ba203956..88383371a5a4 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -967,7 +967,7 @@ static __always_inline void nvme_pci_unmap_rq(struct request *req)
struct nvme_iod *iod = blk_mq_rq_to_pdu(req);
dma_unmap_page(dev->dev, iod->meta_dma,
- rq_integrity_vec(req)->bv_len, rq_data_dir(req));
+ rq_integrity_vec(req)->bv_len, rq_dma_dir(req));
}
if (blk_rq_nr_phys_segments(req))
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-13 15:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-13 9:26 [PATCH] nvme-pci: fix DMA direction of unmapping integrity data Ming Lei
2023-07-13 11:37 ` Christoph Hellwig
2023-07-13 15:19 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox