Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nitesh Shetty <nj.shetty@samsung.com>
To: Jens Axboe <axboe@kernel.dk>, Jonathan Corbet <corbet@lwn.net>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@kernel.org>,
	dm-devel@redhat.com, Keith Busch <kbusch@kernel.org>,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <kch@nvidia.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>
Cc: martin.petersen@oracle.com, mcgrof@kernel.org,
	gost.dev@samsung.com, Nitesh Shetty <nj.shetty@samsung.com>,
	Anuj Gupta <anuj20.g@samsung.com>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-nvme@lists.infradead.org,
	linux-fsdevel@vger.kernel.org
Subject: [PATCH v15 06/12] fs, block: copy_file_range for def_blk_ops for direct block device
Date: Wed,  6 Sep 2023 22:08:31 +0530	[thread overview]
Message-ID: <20230906163844.18754-7-nj.shetty@samsung.com> (raw)
In-Reply-To: <20230906163844.18754-1-nj.shetty@samsung.com>

For direct block device opened with O_DIRECT, use copy_file_range to
issue device copy offload, and fallback to generic_copy_file_range incase
device copy offload capability is absent or the device files are not open
with O_DIRECT.

Signed-off-by: Anuj Gupta <anuj20.g@samsung.com>
Signed-off-by: Nitesh Shetty <nj.shetty@samsung.com>
---
 block/fops.c | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/block/fops.c b/block/fops.c
index a24a624d3bf7..2d96459f3277 100644
--- a/block/fops.c
+++ b/block/fops.c
@@ -739,6 +739,30 @@ static ssize_t blkdev_read_iter(struct kiocb *iocb, struct iov_iter *to)
 	return ret;
 }
 
+static ssize_t blkdev_copy_file_range(struct file *file_in, loff_t pos_in,
+				      struct file *file_out, loff_t pos_out,
+				      size_t len, unsigned int flags)
+{
+	struct block_device *in_bdev = I_BDEV(bdev_file_inode(file_in));
+	struct block_device *out_bdev = I_BDEV(bdev_file_inode(file_out));
+	ssize_t copied = 0;
+
+	if ((in_bdev == out_bdev) && bdev_max_copy_sectors(in_bdev) &&
+	    (file_in->f_iocb_flags & IOCB_DIRECT) &&
+	    (file_out->f_iocb_flags & IOCB_DIRECT)) {
+		copied = blkdev_copy_offload(in_bdev, pos_in, pos_out, len,
+					     NULL, NULL, GFP_KERNEL);
+		if (copied < 0)
+			copied = 0;
+	}
+	if (copied != len)
+		copied = generic_copy_file_range(file_in, pos_in + copied,
+						 file_out, pos_out + copied,
+						 len - copied, flags);
+
+	return copied;
+}
+
 #define	BLKDEV_FALLOC_FL_SUPPORTED					\
 		(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE |		\
 		 FALLOC_FL_ZERO_RANGE | FALLOC_FL_NO_HIDE_STALE)
@@ -832,6 +856,7 @@ const struct file_operations def_blk_fops = {
 	.splice_read	= filemap_splice_read,
 	.splice_write	= iter_file_splice_write,
 	.fallocate	= blkdev_fallocate,
+	.copy_file_range = blkdev_copy_file_range,
 };
 
 static __init int blkdev_init(void)
-- 
2.35.1.500.gb896f729e2



  parent reply	other threads:[~2023-09-06 17:54 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230906164238epcas5p4a511a029fb8ae8bbc36b750712ad64d5@epcas5p4.samsung.com>
2023-09-06 16:38 ` [PATCH v15 00/12] Implement copy offload support Nitesh Shetty
2023-09-06 16:38   ` [PATCH v15 01/12] block: Introduce queue limits and sysfs for copy-offload support Nitesh Shetty
2023-09-07 18:38     ` Luis Chamberlain
2023-09-06 16:38   ` [PATCH v15 02/12] Add infrastructure for copy offload in block and request layer Nitesh Shetty
2023-09-07  5:39     ` Hannes Reinecke
2023-09-07  7:09       ` Nitesh Shetty
2023-09-06 16:38   ` [PATCH v15 03/12] block: add copy offload support Nitesh Shetty
2023-09-07  5:49     ` Hannes Reinecke
2023-09-07  7:16       ` Nitesh Shetty
2023-09-08  5:55         ` Hannes Reinecke
2023-09-06 16:38   ` [PATCH v15 04/12] block: add emulation for copy Nitesh Shetty
2023-09-08  6:06     ` Hannes Reinecke
2023-09-11  7:09       ` Nitesh Shetty
2023-09-11  7:39         ` Hannes Reinecke
2023-09-11 10:20           ` Nitesh Shetty
2023-09-06 16:38   ` [PATCH v15 05/12] fs/read_write: Enable copy_file_range for block device Nitesh Shetty
2023-09-08  6:07     ` Hannes Reinecke
2023-09-06 16:38   ` Nitesh Shetty [this message]
2023-09-08  6:08     ` [PATCH v15 06/12] fs, block: copy_file_range for def_blk_ops for direct " Hannes Reinecke
2023-09-06 16:38   ` [PATCH v15 07/12] nvme: add copy offload support Nitesh Shetty
2023-09-08  6:09     ` Hannes Reinecke
2023-09-06 16:38   ` [PATCH v15 08/12] nvmet: add copy command support for bdev and file ns Nitesh Shetty
2023-09-08  6:11     ` Hannes Reinecke
2023-09-06 16:38   ` [PATCH v15 09/12] dm: Add support for copy offload Nitesh Shetty
2023-09-08  6:13     ` Hannes Reinecke
2023-09-11  7:07       ` Nitesh Shetty
2023-09-11  7:45         ` Hannes Reinecke
2023-09-06 16:38   ` [PATCH v15 10/12] dm: Enable copy offload for dm-linear target Nitesh Shetty
2023-09-08  6:14     ` Hannes Reinecke
2023-09-06 16:38   ` [PATCH v15 11/12] null: Enable trace capability for null block Nitesh Shetty
2023-09-08  6:14     ` Hannes Reinecke
2023-09-06 16:38   ` [PATCH v15 12/12] null_blk: add support for copy offload Nitesh Shetty
2023-09-06 22:01     ` kernel test robot
2023-09-06 22:58     ` kernel test robot
2023-09-08  6:16     ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230906163844.18754-7-nj.shetty@samsung.com \
    --to=nj.shetty@samsung.com \
    --cc=agk@redhat.com \
    --cc=anuj20.g@samsung.com \
    --cc=axboe@kernel.dk \
    --cc=brauner@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dm-devel@redhat.com \
    --cc=gost.dev@samsung.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=martin.petersen@oracle.com \
    --cc=mcgrof@kernel.org \
    --cc=sagi@grimberg.me \
    --cc=snitzer@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox