From: Hannes Reinecke <hare@suse.de>
To: Nitesh Shetty <nj.shetty@samsung.com>
Cc: Jens Axboe <axboe@kernel.dk>, Jonathan Corbet <corbet@lwn.net>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
dm-devel@redhat.com, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
martin.petersen@oracle.com, mcgrof@kernel.org,
gost.dev@samsung.com, Anuj Gupta <anuj20.g@samsung.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v15 03/12] block: add copy offload support
Date: Fri, 8 Sep 2023 07:55:57 +0200 [thread overview]
Message-ID: <9b524f00-35f1-4f6c-896e-40f2879040d2@suse.de> (raw)
In-Reply-To: <20230907071611.rgukw7fory2xh5sy@green245>
On 9/7/23 09:16, Nitesh Shetty wrote:
> On 07/09/23 07:49AM, Hannes Reinecke wrote:
>> On 9/6/23 18:38, Nitesh Shetty wrote:
>>
>> Hmm. That looks a bit odd. Why do you have to use wait_for_completion?
>
> wait_for_completion is waiting for all the copy IOs to complete,
> when caller does not pass endio handler.
> Copy IO submissions are still async, as in previous revisions.
>
>> Can't you submit the 'src' bio, and then submit the 'dst' bio from the
>> endio handler of the 'src' bio?
> We can't do this with the current bio merging approach.
> 'src' bio waits for the 'dst' bio to arrive in request layer.
> Note that both bio's should be present in request reaching the driver,
> to form the copy-cmd.
>
Hmm. I guess it would be possible, but in the end we can always change
it later once the infrastructure is in.
So:
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman
next prev parent reply other threads:[~2023-09-08 5:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230906164238epcas5p4a511a029fb8ae8bbc36b750712ad64d5@epcas5p4.samsung.com>
2023-09-06 16:38 ` [PATCH v15 00/12] Implement copy offload support Nitesh Shetty
2023-09-06 16:38 ` [PATCH v15 01/12] block: Introduce queue limits and sysfs for copy-offload support Nitesh Shetty
2023-09-07 18:38 ` Luis Chamberlain
2023-09-06 16:38 ` [PATCH v15 02/12] Add infrastructure for copy offload in block and request layer Nitesh Shetty
2023-09-07 5:39 ` Hannes Reinecke
2023-09-07 7:09 ` Nitesh Shetty
2023-09-06 16:38 ` [PATCH v15 03/12] block: add copy offload support Nitesh Shetty
2023-09-07 5:49 ` Hannes Reinecke
2023-09-07 7:16 ` Nitesh Shetty
2023-09-08 5:55 ` Hannes Reinecke [this message]
2023-09-06 16:38 ` [PATCH v15 04/12] block: add emulation for copy Nitesh Shetty
2023-09-08 6:06 ` Hannes Reinecke
2023-09-11 7:09 ` Nitesh Shetty
2023-09-11 7:39 ` Hannes Reinecke
2023-09-11 10:20 ` Nitesh Shetty
2023-09-06 16:38 ` [PATCH v15 05/12] fs/read_write: Enable copy_file_range for block device Nitesh Shetty
2023-09-08 6:07 ` Hannes Reinecke
2023-09-06 16:38 ` [PATCH v15 06/12] fs, block: copy_file_range for def_blk_ops for direct " Nitesh Shetty
2023-09-08 6:08 ` Hannes Reinecke
2023-09-06 16:38 ` [PATCH v15 07/12] nvme: add copy offload support Nitesh Shetty
2023-09-08 6:09 ` Hannes Reinecke
2023-09-06 16:38 ` [PATCH v15 08/12] nvmet: add copy command support for bdev and file ns Nitesh Shetty
2023-09-08 6:11 ` Hannes Reinecke
2023-09-06 16:38 ` [PATCH v15 09/12] dm: Add support for copy offload Nitesh Shetty
2023-09-08 6:13 ` Hannes Reinecke
2023-09-11 7:07 ` Nitesh Shetty
2023-09-11 7:45 ` Hannes Reinecke
2023-09-06 16:38 ` [PATCH v15 10/12] dm: Enable copy offload for dm-linear target Nitesh Shetty
2023-09-08 6:14 ` Hannes Reinecke
2023-09-06 16:38 ` [PATCH v15 11/12] null: Enable trace capability for null block Nitesh Shetty
2023-09-08 6:14 ` Hannes Reinecke
2023-09-06 16:38 ` [PATCH v15 12/12] null_blk: add support for copy offload Nitesh Shetty
2023-09-06 22:01 ` kernel test robot
2023-09-06 22:58 ` kernel test robot
2023-09-08 6:16 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b524f00-35f1-4f6c-896e-40f2879040d2@suse.de \
--to=hare@suse.de \
--cc=agk@redhat.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=corbet@lwn.net \
--cc=dm-devel@redhat.com \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=nj.shetty@samsung.com \
--cc=sagi@grimberg.me \
--cc=snitzer@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox