* [PATCH 1/1] nvme: host: changing data type for variable from bool to int.
[not found] <CGME20230912092353epcas5p130b50fa2030574071c41461447fddd52@epcas5p1.samsung.com>
@ 2023-09-12 3:55 ` soni.ankit
2023-09-12 13:03 ` Sagi Grimberg
2023-09-13 15:30 ` Kanchan Joshi
0 siblings, 2 replies; 3+ messages in thread
From: soni.ankit @ 2023-09-12 3:55 UTC (permalink / raw)
To: kbusch, axboe, hch, sagi
Cc: linux-nvme, sathya.m, d.palani, prakash.bv, anshul, Ankit Soni
From: Ankit Soni <soni.ankit@samsung.com>
Changing data type of local variable to make it aligned with
return type of "nvme_poll_cq" function.
Signed-off-by: Ankit Soni <soni.ankit@samsung.com>
Signed-off-by: Sathyavathi M <sathya.m@samsung.com>
---
drivers/nvme/host/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 2f57da12..b328a65 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -1116,7 +1116,7 @@ static void nvme_poll_irqdisable(struct nvme_queue *nvmeq)
static int nvme_poll(struct blk_mq_hw_ctx *hctx, struct io_comp_batch *iob)
{
struct nvme_queue *nvmeq = hctx->driver_data;
- bool found;
+ int found;
if (!nvme_cqe_pending(nvmeq))
return 0;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] nvme: host: changing data type for variable from bool to int.
2023-09-12 3:55 ` [PATCH 1/1] nvme: host: changing data type for variable from bool to int soni.ankit
@ 2023-09-12 13:03 ` Sagi Grimberg
2023-09-13 15:30 ` Kanchan Joshi
1 sibling, 0 replies; 3+ messages in thread
From: Sagi Grimberg @ 2023-09-12 13:03 UTC (permalink / raw)
To: soni.ankit, kbusch, axboe, hch
Cc: linux-nvme, sathya.m, d.palani, prakash.bv, anshul
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] nvme: host: changing data type for variable from bool to int.
2023-09-12 3:55 ` [PATCH 1/1] nvme: host: changing data type for variable from bool to int soni.ankit
2023-09-12 13:03 ` Sagi Grimberg
@ 2023-09-13 15:30 ` Kanchan Joshi
1 sibling, 0 replies; 3+ messages in thread
From: Kanchan Joshi @ 2023-09-13 15:30 UTC (permalink / raw)
To: soni.ankit
Cc: kbusch, axboe, hch, sagi, linux-nvme, sathya.m, d.palani,
prakash.bv, anshul
[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]
On Tue, Sep 12, 2023 at 09:25:11AM +0530, soni.ankit@samsung.com wrote:
>From: Ankit Soni <soni.ankit@samsung.com>
>
>Changing data type of local variable to make it aligned with
>return type of "nvme_poll_cq" function.
>
>Signed-off-by: Ankit Soni <soni.ankit@samsung.com>
>Signed-off-by: Sathyavathi M <sathya.m@samsung.com>
>---
> drivers/nvme/host/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
>index 2f57da12..b328a65 100644
>--- a/drivers/nvme/host/pci.c
>+++ b/drivers/nvme/host/pci.c
>@@ -1116,7 +1116,7 @@ static void nvme_poll_irqdisable(struct nvme_queue *nvmeq)
> static int nvme_poll(struct blk_mq_hw_ctx *hctx, struct io_comp_batch *iob)
> {
> struct nvme_queue *nvmeq = hctx->driver_data;
>- bool found;
>+ int found;
Before this change, the function used to return 1 even if more
completions were reaped underneath.
Not a functional issue, as only place actual count mattered was in
io_uring, but it did not rely on this return anyway and used
completion-batching to process multiple completions.
But this was bit confusing, so good to have this cleaned up.
Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-13 15:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20230912092353epcas5p130b50fa2030574071c41461447fddd52@epcas5p1.samsung.com>
2023-09-12 3:55 ` [PATCH 1/1] nvme: host: changing data type for variable from bool to int soni.ankit
2023-09-12 13:03 ` Sagi Grimberg
2023-09-13 15:30 ` Kanchan Joshi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox