From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, james.smart@broadcom.com,
sagi@grimberg.me, hch@lst.de, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] nvme-fc: set numa_node after nvme_init_ctrl
Date: Wed, 20 Dec 2023 07:37:18 +0100 [thread overview]
Message-ID: <20231220063718.GB1421@lst.de> (raw)
In-Reply-To: <20231219174934.20400-1-kbusch@meta.com>
On Tue, Dec 19, 2023 at 09:49:34AM -0800, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> nvme_init_ctrl() always sets ctrl->numa_node to NUMA_NO_NODE. Set the
> desired value after that function call so it won't be overwritten.
>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-12-20 6:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 17:49 [PATCH] nvme-fc: set numa_node after nvme_init_ctrl Keith Busch
2023-12-19 20:31 ` Sagi Grimberg
2023-12-20 3:15 ` Jens Axboe
2023-12-20 6:37 ` Christoph Hellwig [this message]
2023-12-20 13:43 ` Max Gurtovoy
2023-12-21 17:21 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220063718.GB1421@lst.de \
--to=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox