From: Keith Busch <kbusch@kernel.org>
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: Keith Busch <kbusch@meta.com>,
linux-nvme@lists.infradead.org, james.smart@broadcom.com,
sagi@grimberg.me, hch@lst.de
Subject: Re: [PATCH] nvme-fc: set numa_node after nvme_init_ctrl
Date: Thu, 21 Dec 2023 10:21:58 -0700 [thread overview]
Message-ID: <ZYR0Nk5SwI0Qqb9Z@kbusch-mbp> (raw)
In-Reply-To: <26567ee7-cef8-4484-ad8e-d8b6fbb1d1cb@nvidia.com>
On Wed, Dec 20, 2023 at 03:43:03PM +0200, Max Gurtovoy wrote:
> On 19/12/2023 19:49, Keith Busch wrote:
> > + if (lport->dev)
> > + ctrl->ctrl.numa_node = dev_to_node(lport->dev);
> > + else
> > + ctrl->ctrl.numa_node = NUMA_NO_NODE;
>
> We don't need the "else" clause, it is initialized to NUMA_NO_NODE.
This was just moving the existing hunk, but your suggestion is a nice
bonus cleanup. I've folded it in and applied for nvme-6.8. Thanks!
prev parent reply other threads:[~2023-12-21 17:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 17:49 [PATCH] nvme-fc: set numa_node after nvme_init_ctrl Keith Busch
2023-12-19 20:31 ` Sagi Grimberg
2023-12-20 3:15 ` Jens Axboe
2023-12-20 6:37 ` Christoph Hellwig
2023-12-20 13:43 ` Max Gurtovoy
2023-12-21 17:21 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYR0Nk5SwI0Qqb9Z@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox