* [PATCH V2 1/2] nvme: add module description to stop warnings
@ 2024-01-23 22:13 Chaitanya Kulkarni
2024-01-23 22:13 ` [PATCH V2 2/2] nvmet: " Chaitanya Kulkarni
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Chaitanya Kulkarni @ 2024-01-23 22:13 UTC (permalink / raw)
To: linux-nvme; +Cc: kbusch, hch, james.smart, sagi, Chaitanya Kulkarni
Add MODULE_DESCRIPTION() in order to remove warnings & get clean build:-
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-core.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-fabrics.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-rdma.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-fc.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-tcp.o
Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
---
V2: Update description text. (Sagi)
---
drivers/nvme/host/core.c | 1 +
drivers/nvme/host/fabrics.c | 1 +
drivers/nvme/host/fc.c | 1 +
drivers/nvme/host/pci.c | 1 +
drivers/nvme/host/rdma.c | 1 +
drivers/nvme/host/tcp.c | 1 +
6 files changed, 6 insertions(+)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 85ab0fcf9e88..0810be0d1154 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -4851,5 +4851,6 @@ static void __exit nvme_core_exit(void)
MODULE_LICENSE("GPL");
MODULE_VERSION("1.0");
+MODULE_DESCRIPTION("NVMe host core framework");
module_init(nvme_core_init);
module_exit(nvme_core_exit);
diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
index b5752a77ad98..373ed08e6b92 100644
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host/fabrics.c
@@ -1488,6 +1488,7 @@ static void __exit nvmf_exit(void)
}
MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("NVMe host fabrics library");
module_init(nvmf_init);
module_exit(nvmf_exit);
diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
index 16847a316421..e2308119f8f0 100644
--- a/drivers/nvme/host/fc.c
+++ b/drivers/nvme/host/fc.c
@@ -4004,4 +4004,5 @@ static void __exit nvme_fc_exit_module(void)
module_init(nvme_fc_init_module);
module_exit(nvme_fc_exit_module);
+MODULE_DESCRIPTION("NVMe host FC transport driver");
MODULE_LICENSE("GPL v2");
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index c1d6357ec98a..25eb72779541 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3543,5 +3543,6 @@ static void __exit nvme_exit(void)
MODULE_AUTHOR("Matthew Wilcox <willy@linux.intel.com>");
MODULE_LICENSE("GPL");
MODULE_VERSION("1.0");
+MODULE_DESCRIPTION("NVMe host PCIe transport driver");
module_init(nvme_init);
module_exit(nvme_exit);
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 11dde0d83044..0f48ead986ec 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -2400,4 +2400,5 @@ static void __exit nvme_rdma_cleanup_module(void)
module_init(nvme_rdma_init_module);
module_exit(nvme_rdma_cleanup_module);
+MODULE_DESCRIPTION("NVMe host RDMA transport driver");
MODULE_LICENSE("GPL v2");
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index d058d990532b..4393cf244025 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c
@@ -2826,4 +2826,5 @@ static void __exit nvme_tcp_cleanup_module(void)
module_init(nvme_tcp_init_module);
module_exit(nvme_tcp_cleanup_module);
+MODULE_DESCRIPTION("NVMe host TCP transport driver");
MODULE_LICENSE("GPL v2");
--
2.40.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH V2 2/2] nvmet: add module description to stop warnings
2024-01-23 22:13 [PATCH V2 1/2] nvme: add module description to stop warnings Chaitanya Kulkarni
@ 2024-01-23 22:13 ` Chaitanya Kulkarni
2024-01-24 9:06 ` Christoph Hellwig
2024-01-24 12:51 ` Sagi Grimberg
2024-01-24 9:06 ` [PATCH V2 1/2] nvme: " Christoph Hellwig
` (2 subsequent siblings)
3 siblings, 2 replies; 7+ messages in thread
From: Chaitanya Kulkarni @ 2024-01-23 22:13 UTC (permalink / raw)
To: linux-nvme; +Cc: kbusch, hch, james.smart, sagi, Chaitanya Kulkarni
Add MODULE_DESCRIPTION() in order to remove warnings & get clean build:-
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvmet.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvme-loop.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvmet-rdma.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvmet-fc.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvme-fcloop.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvmet-tcp.o
Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
---
V2: Update description text. (Sagi)
---
V2: Update description. (Sagi)
drivers/nvme/target/core.c | 1 +
drivers/nvme/target/fc.c | 1 +
drivers/nvme/target/fcloop.c | 1 +
drivers/nvme/target/loop.c | 1 +
drivers/nvme/target/rdma.c | 1 +
drivers/nvme/target/tcp.c | 1 +
6 files changed, 6 insertions(+)
diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
index fa35e65915f0..8658e9c08534 100644
--- a/drivers/nvme/target/core.c
+++ b/drivers/nvme/target/core.c
@@ -1705,4 +1705,5 @@ static void __exit nvmet_exit(void)
module_init(nvmet_init);
module_exit(nvmet_exit);
+MODULE_DESCRIPTION("NVMe target core framework");
MODULE_LICENSE("GPL v2");
diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
index bda7a3009e85..05e6a755b330 100644
--- a/drivers/nvme/target/fc.c
+++ b/drivers/nvme/target/fc.c
@@ -2945,4 +2945,5 @@ static void __exit nvmet_fc_exit_module(void)
module_init(nvmet_fc_init_module);
module_exit(nvmet_fc_exit_module);
+MODULE_DESCRIPTION("NVMe target FC transport driver");
MODULE_LICENSE("GPL v2");
diff --git a/drivers/nvme/target/fcloop.c b/drivers/nvme/target/fcloop.c
index ead349af30f1..c1faeb1e9e55 100644
--- a/drivers/nvme/target/fcloop.c
+++ b/drivers/nvme/target/fcloop.c
@@ -1650,4 +1650,5 @@ static void __exit fcloop_exit(void)
module_init(fcloop_init);
module_exit(fcloop_exit);
+MODULE_DESCRIPTION("NVMe target FC loop transport driver");
MODULE_LICENSE("GPL v2");
diff --git a/drivers/nvme/target/loop.c b/drivers/nvme/target/loop.c
index 9cb434c58075..2b2e0d00af85 100644
--- a/drivers/nvme/target/loop.c
+++ b/drivers/nvme/target/loop.c
@@ -688,5 +688,6 @@ static void __exit nvme_loop_cleanup_module(void)
module_init(nvme_loop_init_module);
module_exit(nvme_loop_cleanup_module);
+MODULE_DESCRIPTION("NVMe target loop transport driver");
MODULE_LICENSE("GPL v2");
MODULE_ALIAS("nvmet-transport-254"); /* 254 == NVMF_TRTYPE_LOOP */
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index 667f9c04f35d..3a0f2c170f4c 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -2104,5 +2104,6 @@ static void __exit nvmet_rdma_exit(void)
module_init(nvmet_rdma_init);
module_exit(nvmet_rdma_exit);
+MODULE_DESCRIPTION("NVMe target RDMA transport driver");
MODULE_LICENSE("GPL v2");
MODULE_ALIAS("nvmet-transport-1"); /* 1 == NVMF_TRTYPE_RDMA */
diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c
index 6a1e6bb80062..da0469978d6f 100644
--- a/drivers/nvme/target/tcp.c
+++ b/drivers/nvme/target/tcp.c
@@ -2221,5 +2221,6 @@ static void __exit nvmet_tcp_exit(void)
module_init(nvmet_tcp_init);
module_exit(nvmet_tcp_exit);
+MODULE_DESCRIPTION("NVMe target TCP transport driver");
MODULE_LICENSE("GPL v2");
MODULE_ALIAS("nvmet-transport-3"); /* 3 == NVMF_TRTYPE_TCP */
--
2.40.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH V2 1/2] nvme: add module description to stop warnings
2024-01-23 22:13 [PATCH V2 1/2] nvme: add module description to stop warnings Chaitanya Kulkarni
2024-01-23 22:13 ` [PATCH V2 2/2] nvmet: " Chaitanya Kulkarni
@ 2024-01-24 9:06 ` Christoph Hellwig
2024-01-24 12:51 ` Sagi Grimberg
2024-01-24 15:27 ` Keith Busch
3 siblings, 0 replies; 7+ messages in thread
From: Christoph Hellwig @ 2024-01-24 9:06 UTC (permalink / raw)
To: Chaitanya Kulkarni; +Cc: linux-nvme, kbusch, hch, james.smart, sagi
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2 1/2] nvme: add module description to stop warnings
2024-01-23 22:13 [PATCH V2 1/2] nvme: add module description to stop warnings Chaitanya Kulkarni
2024-01-23 22:13 ` [PATCH V2 2/2] nvmet: " Chaitanya Kulkarni
2024-01-24 9:06 ` [PATCH V2 1/2] nvme: " Christoph Hellwig
@ 2024-01-24 12:51 ` Sagi Grimberg
2024-01-24 15:27 ` Keith Busch
3 siblings, 0 replies; 7+ messages in thread
From: Sagi Grimberg @ 2024-01-24 12:51 UTC (permalink / raw)
To: Chaitanya Kulkarni, linux-nvme; +Cc: kbusch, hch, james.smart
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2 1/2] nvme: add module description to stop warnings
2024-01-23 22:13 [PATCH V2 1/2] nvme: add module description to stop warnings Chaitanya Kulkarni
` (2 preceding siblings ...)
2024-01-24 12:51 ` Sagi Grimberg
@ 2024-01-24 15:27 ` Keith Busch
3 siblings, 0 replies; 7+ messages in thread
From: Keith Busch @ 2024-01-24 15:27 UTC (permalink / raw)
To: Chaitanya Kulkarni; +Cc: linux-nvme, hch, james.smart, sagi
Thanks, series applied to nvme-6.8.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-01-24 15:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-23 22:13 [PATCH V2 1/2] nvme: add module description to stop warnings Chaitanya Kulkarni
2024-01-23 22:13 ` [PATCH V2 2/2] nvmet: " Chaitanya Kulkarni
2024-01-24 9:06 ` Christoph Hellwig
2024-01-24 12:51 ` Sagi Grimberg
2024-01-24 9:06 ` [PATCH V2 1/2] nvme: " Christoph Hellwig
2024-01-24 12:51 ` Sagi Grimberg
2024-01-24 15:27 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox