public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Israel Rukshin <israelr@nvidia.com>
Cc: Christoph Hellwig <hch@lst.de>, Daniel Wagner <dwagner@suse.de>,
	Max Gurtovoy <mgurtovoy@nvidia.com>,
	kbusch@kernel.org, sagi@grimberg.me,
	linux-nvme@lists.infradead.org, oren@nvidia.com,
	oevron@nvidia.com
Subject: Re: [PATCH 7/8] nvme-fabrics: add option to disallow T10-PI offload
Date: Tue, 13 Feb 2024 08:16:03 +0100	[thread overview]
Message-ID: <20240213071603.GA24160@lst.de> (raw)
In-Reply-To: <fdd1c81f-caf3-4f34-96e8-f4d8ffc26203@nvidia.com>

On Thu, Feb 01, 2024 at 10:28:50AM +0200, Israel Rukshin wrote:
> Do you mean to do something like the bellow diff?

Yes.

> Regarding extending the existing boolean flags, are you talking about 
> hdr_digest, disable_sqflow, data_digest, discovery, duplicate_connect and 
> tls flags?
>
> I will try to do it without breaking the existing nvmecli, but I am not 
> sure if it is possible.

I'm pretty sure we have a bunch of fs mount options that allow a version
with paramters and without.  dax is an example, but you might have to
look at older kernels as the dax-supporting file systems got converted
to the new mount API in the meantime.



  parent reply	other threads:[~2024-02-13  7:16 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-22 14:56 [PATCH v1 0/8] Enforce uniform metadata settings for ns head Max Gurtovoy
2024-01-22 14:56 ` [PATCH 1/8] nvme: use Independent ID-NS only for unknown cmd sets Max Gurtovoy
2024-01-23  8:58   ` Christoph Hellwig
2024-01-22 14:56 ` [PATCH 2/8] nvme: set uniform metadata settings for ns head Max Gurtovoy
2024-01-23  9:01   ` Christoph Hellwig
2024-01-22 14:56 ` [PATCH 3/8] nvme: allocate a new namespace if validation fail Max Gurtovoy
2024-01-23  9:02   ` Christoph Hellwig
2024-01-22 14:56 ` [PATCH 4/8] nvme: add nvme_queue_scan_sync helper Max Gurtovoy
2024-01-22 14:56 ` [PATCH 5/8] nvme: sync the namespace scanning during ctrl start Max Gurtovoy
2024-01-23  9:02   ` Christoph Hellwig
2024-01-24  0:47     ` Max Gurtovoy
2024-01-24  9:48       ` Christoph Hellwig
2024-01-24 10:23         ` Max Gurtovoy
2024-01-25 14:41           ` Christoph Hellwig
2024-01-25 15:55             ` Max Gurtovoy
2024-01-29 10:48               ` Sagi Grimberg
2024-01-29 12:37                 ` Max Gurtovoy
2024-01-31 12:40                   ` Sagi Grimberg
2024-01-31 13:10                     ` Christoph Hellwig
2024-01-24 12:58   ` Sagi Grimberg
2024-01-24 13:04     ` Max Gurtovoy
2024-01-24 13:10       ` Sagi Grimberg
2024-01-24 13:17         ` Max Gurtovoy
2024-01-24 13:54           ` Sagi Grimberg
2024-01-24 14:15             ` Max Gurtovoy
2024-01-22 14:56 ` [PATCH 6/8] nvme-rdma: Fix transfer length when write_generate/read_verify are 0 Max Gurtovoy
2024-01-23  9:02   ` Christoph Hellwig
2024-01-22 14:56 ` [PATCH 7/8] nvme-fabrics: add option to disallow T10-PI offload Max Gurtovoy
2024-01-22 15:13   ` Daniel Wagner
2024-01-22 15:17     ` Max Gurtovoy
2024-01-22 15:27       ` Daniel Wagner
2024-01-22 15:28         ` Daniel Wagner
2024-01-23  9:04           ` Christoph Hellwig
2024-02-01 10:40             ` Israel Rukshin
     [not found]             ` <fdd1c81f-caf3-4f34-96e8-f4d8ffc26203@nvidia.com>
2024-02-13  7:16               ` Christoph Hellwig [this message]
2024-01-22 14:56 ` [PATCH 8/8] nvme-rdma: enable user " Max Gurtovoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240213071603.GA24160@lst.de \
    --to=hch@lst.de \
    --cc=dwagner@suse.de \
    --cc=israelr@nvidia.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mgurtovoy@nvidia.com \
    --cc=oevron@nvidia.com \
    --cc=oren@nvidia.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox