From: Bjorn Helgaas <helgaas@kernel.org>
To: Saravana Kannan <saravanak@google.com>
Cc: Christoph Hellwig <hch@lst.de>, Jeremy Allison <jallison@ciq.com>,
jra@samba.org, tansuresh@google.com, gregkh@linuxfoundation.org,
rafael@kernel.org, bhelgaas@google.com, sagi@grimberg.me,
linux-nvme@lists.infradead.org,
Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH 1/5] driver core: Support two-pass driver shutdown.
Date: Wed, 14 Feb 2024 16:10:17 -0600 [thread overview]
Message-ID: <20240214221017.GA1268794@bhelgaas> (raw)
In-Reply-To: <CAGETcx9WiPUcVkU3bc3-HA7WN_Mq4JaBZB9HQn+LE0F26Tte1w@mail.gmail.com>
On Wed, Feb 14, 2024 at 01:36:28PM -0800, Saravana Kannan wrote:
> On Wed, Feb 14, 2024 at 12:10 AM Christoph Hellwig <hch@lst.de> wrote:
> > On Tue, Feb 13, 2024 at 07:36:35PM -0800, Saravana Kannan wrote:
> > > > This changes the bus driver interface with an additional entry point
> > > > to enable devices to implement two-pass shutdown. The existing
> > > > synchronous interface to shutdown is called, and if a shutdown_wait
> > > > method is defined the device is moved to an alternate list.
> > >
> > > This sounds more like you need a parallelized async shutdown than a
> > > two-pass shutdown. Similar to how async probes are done today. Why not
> > > do that so it'll actually be useful in a more general fashion? You can
> > > even add a flag like we have for probes so that drivers don't need to
> > > do anything special to allow this parallelism.
> >
> > Well, we had that discussion before.
>
> Can you point me to this please? I looked around and wasn't able to
> find it.
I'm not sure what Christoph had in mind, but he might be referring to
this:
https://lore.kernel.org/r/20231227203337.GA1509884@bhelgaas
Bjorn
next prev parent reply other threads:[~2024-02-14 22:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 18:19 Make NVME shutdown two-pass - Version 5 Jeremy Allison
2024-01-29 18:19 ` [PATCH 1/5] driver core: Support two-pass driver shutdown Jeremy Allison
2024-01-30 10:00 ` Sagi Grimberg
2024-02-14 3:36 ` Saravana Kannan
2024-02-14 8:10 ` Christoph Hellwig
2024-02-14 21:36 ` Saravana Kannan
2024-02-14 22:10 ` Bjorn Helgaas [this message]
2024-01-29 18:19 ` [PATCH 2/5] PCI: Support two-pass shutdown Jeremy Allison
2024-01-30 10:00 ` Sagi Grimberg
2024-01-30 17:54 ` Bjorn Helgaas
2024-01-29 18:19 ` [PATCH 3/5] nvme: Change 'bool shutdown' into an enum shutdown_type for nvme_dev_disable() Jeremy Allison
2024-01-30 11:00 ` Sagi Grimberg
2024-01-31 6:19 ` Christoph Hellwig
2024-01-29 18:19 ` [PATCH 4/5] nvme: Add a new exported function nvme_request_shutdown() Jeremy Allison
2024-01-30 10:58 ` Sagi Grimberg
2024-01-30 17:31 ` Jeremy Allison
2024-01-31 6:20 ` Christoph Hellwig
2024-01-29 18:19 ` [PATCH 5/5] nvme: Add two-pass shutdown support Jeremy Allison
2024-01-30 11:15 ` Sagi Grimberg
2024-01-30 18:54 ` Jeremy Allison
-- strict thread matches above, loose matches on Subject: below --
2024-02-07 21:40 Make NVME shutdown two-pass - Version 6 Jeremy Allison
2024-02-07 21:40 ` [PATCH 1/5] driver core: Support two-pass driver shutdown Jeremy Allison
2024-01-03 21:04 Make NVME shutdown two-pass - Version 4 Jeremy Allison
2024-01-03 21:04 ` [PATCH 1/5] driver core: Support two-pass driver shutdown Jeremy Allison
2024-01-04 13:12 ` Sagi Grimberg
2024-01-04 17:27 ` Jeremy Allison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240214221017.GA1268794@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jallison@ciq.com \
--cc=jra@samba.org \
--cc=kernel-team@android.com \
--cc=linux-nvme@lists.infradead.org \
--cc=rafael@kernel.org \
--cc=sagi@grimberg.me \
--cc=saravanak@google.com \
--cc=tansuresh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox