From: Daniel Wagner <dwagner@suse.de>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: Chaitanya Kulkarni <chaitanyak@nvidia.com>,
Keith Busch <kbusch@kernel.org>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Daniel Wagner <dwagner@suse.de>,
Chaitanya Kulkarni <kch@nvidia.com>
Subject: [PATCH blktests v2 1/2] nvme/048: remove unused argument for set_qid_max
Date: Mon, 4 Mar 2024 14:48:25 +0100 [thread overview]
Message-ID: <20240304134826.31965-2-dwagner@suse.de> (raw)
In-Reply-To: <20240304134826.31965-1-dwagner@suse.de>
The port is argument is unsed, thus remove it.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
tests/nvme/048 | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/tests/nvme/048 b/tests/nvme/048
index 1e5a7a1bcb99..8c314fae9620 100755
--- a/tests/nvme/048
+++ b/tests/nvme/048
@@ -69,9 +69,8 @@ set_nvmet_attr_qid_max() {
}
set_qid_max() {
- local port="$1"
- local subsys_name="$2"
- local qid_max="$3"
+ local subsys_name="$1"
+ local qid_max="$2"
set_nvmet_attr_qid_max "${subsys_name}" "${qid_max}"
nvmf_wait_for_state "${subsys_name}" "live" || return 1
@@ -100,8 +99,8 @@ test() {
if ! nvmf_wait_for_state "${def_subsysnqn}" "live" ; then
echo FAIL
else
- set_qid_max "${port}" "${def_subsysnqn}" 1 || echo FAIL
- set_qid_max "${port}" "${def_subsysnqn}" 2 || echo FAIL
+ set_qid_max "${def_subsysnqn}" 1 || echo FAIL
+ set_qid_max "${def_subsysnqn}" 2 || echo FAIL
fi
_nvme_disconnect_subsys "${def_subsysnqn}"
--
2.44.0
next prev parent reply other threads:[~2024-03-04 13:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 13:48 [PATCH blktests v2 0/2] make nvme/048 checks more robust Daniel Wagner
2024-03-04 13:48 ` Daniel Wagner [this message]
2024-03-04 13:48 ` [PATCH blktests v2 2/2] nvme/048: make queue count check retry-able Daniel Wagner
2024-03-05 1:29 ` [PATCH blktests v2 0/2] make nvme/048 checks more robust Shinichiro Kawasaki
2024-03-05 7:20 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304134826.31965-2-dwagner@suse.de \
--to=dwagner@suse.de \
--cc=chaitanyak@nvidia.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox