From: Daniel Wagner <dwagner@suse.de>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: Chaitanya Kulkarni <chaitanyak@nvidia.com>,
Keith Busch <kbusch@kernel.org>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Daniel Wagner <dwagner@suse.de>,
Chaitanya Kulkarni <kch@nvidia.com>
Subject: [PATCH blktests v2 2/2] nvme/048: make queue count check retry-able
Date: Mon, 4 Mar 2024 14:48:26 +0100 [thread overview]
Message-ID: <20240304134826.31965-3-dwagner@suse.de> (raw)
In-Reply-To: <20240304134826.31965-1-dwagner@suse.de>
We are racing with the reset path of the controller. That means, when we
set a new queue count, we might not observe the resetting state in time.
Thus, first check if we see the correct queue count and then the
controller state.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
tests/nvme/048 | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/tests/nvme/048 b/tests/nvme/048
index 8c314fae9620..393dbc2a07d5 100755
--- a/tests/nvme/048
+++ b/tests/nvme/048
@@ -47,11 +47,25 @@ nvmf_check_queue_count() {
local queue_count="$2"
local nvmedev
local queue_count_file
+ local retries
nvmedev=$(_find_nvme_dev "${subsys_name}")
+ queue_count=$((queue_count + 1))
+ retries=5
+
queue_count_file=$(cat /sys/class/nvme-fabrics/ctl/"${nvmedev}"/queue_count)
+ while [[ "${queue_count}" -ne "${queue_count_file}" ]]; do
+ if [[ "${retries}" == 0 ]]; then
+ echo "expected queue count ${queue_count} not set"
+ return 1
+ fi
+
+ sleep 1
+
+ retries=$((retries - 1))
+ queue_count_file=$(cat /sys/class/nvme-fabrics/ctl/"${nvmedev}"/queue_count)
+ done
- queue_count=$((queue_count + 1))
if [[ "${queue_count}" -ne "${queue_count_file}" ]]; then
echo "expected queue count ${queue_count} not set"
return 1
@@ -73,8 +87,8 @@ set_qid_max() {
local qid_max="$2"
set_nvmet_attr_qid_max "${subsys_name}" "${qid_max}"
- nvmf_wait_for_state "${subsys_name}" "live" || return 1
nvmf_check_queue_count "${subsys_name}" "${qid_max}" || return 1
+ nvmf_wait_for_state "${subsys_name}" "live" || return 1
return 0
}
--
2.44.0
next prev parent reply other threads:[~2024-03-04 13:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 13:48 [PATCH blktests v2 0/2] make nvme/048 checks more robust Daniel Wagner
2024-03-04 13:48 ` [PATCH blktests v2 1/2] nvme/048: remove unused argument for set_qid_max Daniel Wagner
2024-03-04 13:48 ` Daniel Wagner [this message]
2024-03-05 1:29 ` [PATCH blktests v2 0/2] make nvme/048 checks more robust Shinichiro Kawasaki
2024-03-05 7:20 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304134826.31965-3-dwagner@suse.de \
--to=dwagner@suse.de \
--cc=chaitanyak@nvidia.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox