Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maurizio Lombardi <mlombard@redhat.com>
To: kbusch@kernel.org
Cc: sagi@grimberg.me, hare@suse.de, dwagner@suse.de,
	linux-nvme@lists.infradead.org
Subject: [PATCH 2/2] nvmet-auth: replace pr_debug() with pr_err() to report an error.
Date: Wed, 10 Apr 2024 11:48:42 +0200	[thread overview]
Message-ID: <20240410094842.370170-3-mlombard@redhat.com> (raw)
In-Reply-To: <20240410094842.370170-1-mlombard@redhat.com>

In nvmet_auth_host_hash(), if a mismatch is detected in the hash length
the kernel should print an error.

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
---
 drivers/nvme/target/auth.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/nvme/target/auth.c b/drivers/nvme/target/auth.c
index 9e51c064b072..fb518b00f71f 100644
--- a/drivers/nvme/target/auth.c
+++ b/drivers/nvme/target/auth.c
@@ -285,9 +285,9 @@ int nvmet_auth_host_hash(struct nvmet_req *req, u8 *response,
 	}
 
 	if (shash_len != crypto_shash_digestsize(shash_tfm)) {
-		pr_debug("%s: hash len mismatch (len %d digest %d)\n",
-			 __func__, shash_len,
-			 crypto_shash_digestsize(shash_tfm));
+		pr_err("%s: hash len mismatch (len %d digest %d)\n",
+			__func__, shash_len,
+			crypto_shash_digestsize(shash_tfm));
 		ret = -EINVAL;
 		goto out_free_tfm;
 	}
-- 
2.39.3



  parent reply	other threads:[~2024-04-10  9:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-10  9:48 [PATCH 0/2] nvmet-auth: fix some minor bugs Maurizio Lombardi
2024-04-10  9:48 ` [PATCH 1/2] nvmet-auth: return the error code to the nvmet_auth_host_hash() callers Maurizio Lombardi
2024-04-10 13:57   ` Sagi Grimberg
2024-04-16  2:51   ` Chaitanya Kulkarni
2024-04-10  9:48 ` Maurizio Lombardi [this message]
2024-04-10 13:57   ` [PATCH 2/2] nvmet-auth: replace pr_debug() with pr_err() to report an error Sagi Grimberg
2024-04-16  2:51   ` Chaitanya Kulkarni
2024-04-16 16:44 ` [PATCH 0/2] nvmet-auth: fix some minor bugs Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240410094842.370170-3-mlombard@redhat.com \
    --to=mlombard@redhat.com \
    --cc=dwagner@suse.de \
    --cc=hare@suse.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox