Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Maurizio Lombardi <mlombard@redhat.com>,
	"kbusch@kernel.org" <kbusch@kernel.org>
Cc: "sagi@grimberg.me" <sagi@grimberg.me>,
	"hare@suse.de" <hare@suse.de>,
	"dwagner@suse.de" <dwagner@suse.de>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH 2/2] nvmet-auth: replace pr_debug() with pr_err() to report an error.
Date: Tue, 16 Apr 2024 02:51:44 +0000	[thread overview]
Message-ID: <32f5f7d1-bf44-428b-a19b-982d5d1f514c@nvidia.com> (raw)
In-Reply-To: <20240410094842.370170-3-mlombard@redhat.com>

On 4/10/24 02:48, Maurizio Lombardi wrote:
> In nvmet_auth_host_hash(), if a mismatch is detected in the hash length
> the kernel should print an error.
>
> Signed-off-by: Maurizio Lombardi<mlombard@redhat.com>
> ---
>   drivers/nvme/target/auth.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck



  parent reply	other threads:[~2024-04-16  2:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-10  9:48 [PATCH 0/2] nvmet-auth: fix some minor bugs Maurizio Lombardi
2024-04-10  9:48 ` [PATCH 1/2] nvmet-auth: return the error code to the nvmet_auth_host_hash() callers Maurizio Lombardi
2024-04-10 13:57   ` Sagi Grimberg
2024-04-16  2:51   ` Chaitanya Kulkarni
2024-04-10  9:48 ` [PATCH 2/2] nvmet-auth: replace pr_debug() with pr_err() to report an error Maurizio Lombardi
2024-04-10 13:57   ` Sagi Grimberg
2024-04-16  2:51   ` Chaitanya Kulkarni [this message]
2024-04-16 16:44 ` [PATCH 0/2] nvmet-auth: fix some minor bugs Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32f5f7d1-bf44-428b-a19b-982d5d1f514c@nvidia.com \
    --to=chaitanyak@nvidia.com \
    --cc=dwagner@suse.de \
    --cc=hare@suse.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mlombard@redhat.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox