From: Martin Wilck <martin.wilck@suse.com>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Nilay Shroff <nilay@linux.ibm.com>,
Daniel Wagner <dwagner@suse.de>
Cc: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Hannes Reinecke <hare@suse.de>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Martin Wilck <mwilck@suse.com>
Subject: [PATCH v2 2/3] blktests: nvme/032: skip on non-PCI devices
Date: Fri, 23 Aug 2024 22:08:20 +0200 [thread overview]
Message-ID: <20240823200822.129867-2-mwilck@suse.com> (raw)
In-Reply-To: <20240823200822.129867-1-mwilck@suse.com>
nvme/032 is a PCI-specific test.
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
tests/nvme/032 | 2 +-
tests/nvme/rc | 8 ++++++++
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/tests/nvme/032 b/tests/nvme/032
index 5353e96..512d7ea 100755
--- a/tests/nvme/032
+++ b/tests/nvme/032
@@ -24,7 +24,7 @@ requires() {
}
device_requires() {
- _require_test_dev_is_nvme
+ _require_test_dev_is_nvme_pci
}
test_device() {
diff --git a/tests/nvme/rc b/tests/nvme/rc
index 5c554b6..b702a57 100644
--- a/tests/nvme/rc
+++ b/tests/nvme/rc
@@ -130,6 +130,14 @@ _require_test_dev_is_nvme() {
return 0
}
+_require_test_dev_is_nvme_pci() {
+ if [[ ! "$(readlink -f "$TEST_DEV_SYSFS/device")" =~ devices/pci ]]; then
+ SKIP_REASONS+=("$TEST_DEV is not a PCI NVMe device")
+ return 1
+ fi
+ return 0
+}
+
_require_test_dev_is_not_nvme_multipath() {
if [[ "$(readlink -f "$TEST_DEV_SYSFS/device")" =~ /nvme-subsystem/ ]]; then
SKIP_REASONS+=("$TEST_DEV is a NVMe multipath device")
--
2.46.0
next prev parent reply other threads:[~2024-08-23 20:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 20:08 [PATCH v2 1/3] blktests: nvme: skip passthru tests on multipath devices Martin Wilck
2024-08-23 20:08 ` Martin Wilck [this message]
2024-08-23 20:08 ` [PATCH v2 3/3] nvme: add test for controller rescan under I/O load Martin Wilck
2024-08-26 5:37 ` Nilay Shroff
2024-08-26 7:58 ` Martin Wilck
2024-08-29 7:36 ` Shinichiro Kawasaki
2024-09-02 13:53 ` Martin Wilck
2024-09-03 0:16 ` Shinichiro Kawasaki
2024-09-03 15:07 ` Martin Wilck
2024-08-29 7:40 ` [PATCH v2 1/3] blktests: nvme: skip passthru tests on multipath devices Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240823200822.129867-2-mwilck@suse.com \
--to=martin.wilck@suse.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mwilck@suse.com \
--cc=nilay@linux.ibm.com \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox