From: Martin Wilck <mwilck@suse.com>
To: Nilay Shroff <nilay@linux.ibm.com>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Daniel Wagner <dwagner@suse.de>
Cc: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Hannes Reinecke <hare@suse.de>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2 3/3] nvme: add test for controller rescan under I/O load
Date: Mon, 26 Aug 2024 09:58:58 +0200 [thread overview]
Message-ID: <3be250bbaede895861092d055d9f49a71566a78f.camel@suse.com> (raw)
In-Reply-To: <2a550653-89b4-4c3c-840a-a905152adb5f@linux.ibm.com>
On Mon, 2024-08-26 at 11:07 +0530, Nilay Shroff wrote:
> >
> The "rand()" function in 'awk' returns a floating point value between
> 0 and 1 (i.e. [0, 1]). So it's possible to have sleep for some cases
> go
> upto ~5.1 seconds. So if the intention is to sleep between 0.1 and 5
> seconds precisely then we may want to use,
>
> sleep(0.1 + 4.9 * rand());
>
Yes, I know. I thought it didn't really matter as the 5s limit was
arbitrary anyway.
> However this is not a major problem and we may ignore.
> Otherwise, code looks good to me.
>
> Reviewed-by: Nilay Shroff (nilay@linux.ibm.com)
>
Thanks!
Martin
next prev parent reply other threads:[~2024-08-26 7:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 20:08 [PATCH v2 1/3] blktests: nvme: skip passthru tests on multipath devices Martin Wilck
2024-08-23 20:08 ` [PATCH v2 2/3] blktests: nvme/032: skip on non-PCI devices Martin Wilck
2024-08-23 20:08 ` [PATCH v2 3/3] nvme: add test for controller rescan under I/O load Martin Wilck
2024-08-26 5:37 ` Nilay Shroff
2024-08-26 7:58 ` Martin Wilck [this message]
2024-08-29 7:36 ` Shinichiro Kawasaki
2024-09-02 13:53 ` Martin Wilck
2024-09-03 0:16 ` Shinichiro Kawasaki
2024-09-03 15:07 ` Martin Wilck
2024-08-29 7:40 ` [PATCH v2 1/3] blktests: nvme: skip passthru tests on multipath devices Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3be250bbaede895861092d055d9f49a71566a78f.camel@suse.com \
--to=mwilck@suse.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox