From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] nvme-pci: allocate tagset on reset if necessary
Date: Tue, 27 Aug 2024 07:49:23 +0200 [thread overview]
Message-ID: <20240827054923.GA11156@lst.de> (raw)
In-Reply-To: <20240826182719.3830725-1-kbusch@meta.com>
On Mon, Aug 26, 2024 at 11:27:19AM -0700, Keith Busch wrote:
> + if (!dev->ctrl.tagset) {
> + nvme_alloc_io_tag_set(&dev->ctrl, &dev->tagset, &nvme_mq_ops,
> + nvme_pci_nr_maps(dev), sizeof(struct nvme_iod));
> + } else {
> + blk_mq_update_nr_hw_queues(&dev->tagset, dev->online_queues - 1);
Overly long line here. Maybe just return early after the allocation
above?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-08-27 5:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 18:27 [PATCH] nvme-pci: allocate tagset on reset if necessary Keith Busch
2024-08-27 5:49 ` Christoph Hellwig [this message]
2024-08-27 14:57 ` Keith Busch
2024-08-27 8:13 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827054923.GA11156@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox