From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@meta.com>,
linux-nvme@lists.infradead.org, sagi@grimberg.me
Subject: Re: [PATCH] nvme-pci: allocate tagset on reset if necessary
Date: Tue, 27 Aug 2024 08:57:52 -0600 [thread overview]
Message-ID: <Zs3pcKTuruSHp8IV@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20240827054923.GA11156@lst.de>
On Tue, Aug 27, 2024 at 07:49:23AM +0200, Christoph Hellwig wrote:
> On Mon, Aug 26, 2024 at 11:27:19AM -0700, Keith Busch wrote:
> > + if (!dev->ctrl.tagset) {
> > + nvme_alloc_io_tag_set(&dev->ctrl, &dev->tagset, &nvme_mq_ops,
> > + nvme_pci_nr_maps(dev), sizeof(struct nvme_iod));
> > + } else {
> > + blk_mq_update_nr_hw_queues(&dev->tagset, dev->online_queues - 1);
>
> Overly long line here. Maybe just return early after the allocation
> above?
Done.
I think I should also add more details to the change log because this
bug does cause a kernel crash. I think this is the first commit that
removed tagset allocation from reset_work:
Fixes: eac3ef262941f62 ("nvme-pci: split the initial probe from the rest path")
>
next prev parent reply other threads:[~2024-08-27 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 18:27 [PATCH] nvme-pci: allocate tagset on reset if necessary Keith Busch
2024-08-27 5:49 ` Christoph Hellwig
2024-08-27 14:57 ` Keith Busch [this message]
2024-08-27 8:13 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zs3pcKTuruSHp8IV@kbusch-mbp.dhcp.thefacebook.com \
--to=kbusch@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox