* [PATCH] nvme: Open brace following function definition on next line
@ 2024-09-18 13:29 Andreas Kühn
2024-09-19 7:41 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Kühn @ 2024-09-18 13:29 UTC (permalink / raw)
To: kbusch, axboe, hch, sagi; +Cc: Andreas Kühn, linux-nvme, linux-kernel
Open brace following function definition go on the next line. Fix it.
Signed-off-by: Andreas Kühn <andreas.kuehn@diekuehnen.com>
---
drivers/nvme/host/constants.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/constants.c b/drivers/nvme/host/constants.c
index 2b9e6cfaf2a8..66d6158822c5 100644
--- a/drivers/nvme/host/constants.c
+++ b/drivers/nvme/host/constants.c
@@ -195,7 +195,8 @@ const char *nvme_get_admin_opcode_str(u8 opcode)
}
EXPORT_SYMBOL_GPL(nvme_get_admin_opcode_str);
-const char *nvme_get_fabrics_opcode_str(u8 opcode) {
+const char *nvme_get_fabrics_opcode_str(u8 opcode)
+{
if (opcode < ARRAY_SIZE(nvme_fabrics_ops) && nvme_fabrics_ops[opcode])
return nvme_fabrics_ops[opcode];
return "Unknown";
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] nvme: Open brace following function definition on next line
2024-09-18 13:29 [PATCH] nvme: Open brace following function definition on next line Andreas Kühn
@ 2024-09-19 7:41 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2024-09-19 7:41 UTC (permalink / raw)
To: Andreas Kühn; +Cc: kbusch, axboe, hch, sagi, linux-nvme, linux-kernel
On Wed, Sep 18, 2024 at 03:29:35PM +0200, Andreas Kühn wrote:
> Open brace following function definition go on the next line. Fix it.
That's indeed our usual style, but random drive by cleanup aren't
really all that helpful and just create clutter.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-19 7:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-18 13:29 [PATCH] nvme: Open brace following function definition on next line Andreas Kühn
2024-09-19 7:41 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox