From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: gjoyce@linux.ibm.com, linux-nvme@lists.infradead.org,
axboe@fb.com, hch@lst.de, sagi@grimberg.me, hare@suse.de,
dwagner@suse.de, msuchanek@suse.de, jonathan.derrick@linux.dev,
okozina@redhat.com, nilay@linux.ibm.com
Subject: Re: [PATCH v2 1/1] nvme: disable CC.CRIME (NVME_CC_CRIME)
Date: Wed, 9 Oct 2024 09:51:52 +0200 [thread overview]
Message-ID: <20241009075152.GA16494@lst.de> (raw)
In-Reply-To: <ZwVtf52gL1Zg_YYQ@kbusch-mbp>
On Tue, Oct 08, 2024 at 11:35:59AM -0600, Keith Busch wrote:
> > Disable NVME_CC_CRIME so that CSTS.RDY indicates that the media
> > is ready and able to handle commands without returning
> > NVME_SC_ADMIN_COMMAND_MEDIA_NOT_READY.
>
> I'm okay with this. We just need to see if Christoph wants to chime in
> since he added the without media ready support. I never saw the value in
> having Linux use it, but maybe there's a good reason to do it.
It think it is useful not to block bringing the admin queue up on
the media timeout. But given how fucked up implementations are we
might as well remove the support for now.
next prev parent reply other threads:[~2024-10-09 7:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 19:33 [PATCH v2 0/1] nvme: disable CC.CRIME (NVME_CC_CRIME) gjoyce
2024-10-07 19:33 ` [PATCH v2 1/1] " gjoyce
2024-10-08 15:45 ` Nilay Shroff
2024-10-08 17:35 ` Keith Busch
2024-10-09 7:51 ` Christoph Hellwig [this message]
2024-10-09 19:47 ` Keith Busch
2024-10-09 22:04 ` Keith Busch
2024-10-10 16:11 ` Greg Joyce
2024-10-10 16:16 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241009075152.GA16494@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=dwagner@suse.de \
--cc=gjoyce@linux.ibm.com \
--cc=hare@suse.de \
--cc=jonathan.derrick@linux.dev \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=msuchanek@suse.de \
--cc=nilay@linux.ibm.com \
--cc=okozina@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox