From: Greg Joyce <gjoyce@linux.ibm.com>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-nvme@lists.infradead.org, axboe@fb.com, hch@lst.de,
sagi@grimberg.me, hare@suse.de, dwagner@suse.de,
msuchanek@suse.de, jonathan.derrick@linux.dev,
okozina@redhat.com, nilay@linux.ibm.com
Subject: Re: [PATCH v2 1/1] nvme: disable CC.CRIME (NVME_CC_CRIME)
Date: Thu, 10 Oct 2024 11:11:43 -0500 [thread overview]
Message-ID: <d82996a73ba89098bbf2b61733849633612c090a.camel@linux.ibm.com> (raw)
In-Reply-To: <Zwb98YIioIGRAQBe@kbusch-mbp>
On Wed, 2024-10-09 at 16:04 -0600, Keith Busch wrote:
> On Mon, Oct 07, 2024 at 02:33:24PM -0500, gjoyce@linux.ibm.com wrote:
> > + /*
> > + * Setting CRIME results in CSTS.RDY before the media is
> > ready. This
> > + * make it possible for media related commands to return
> > the error
> > + * NVME_SC_ADMIN_COMMAND_MEDIA_NOT_READY. Until the driver
> > is
> > + * restructurade to handle retries, disable CC.CRIME.
> > + */
> > + ctrl->ctrl_config &= ~NVME_CC_CRIME;
>
> We could just delete this section entirely. Nothing else sets CRIME,
> so
> no need to explicitly clear it here. I guess it serves to provide a
> place for the explanation, I think we can remove the flag setting
> anyway.
I went back on forth on that. What I do like is that explicitly shows
that CRIME is not being set and why. But you're right, it's really more
of an elaborate comment.
I have no problems with removing it. Would you like me to send a new
patch?
Greg
next prev parent reply other threads:[~2024-10-10 16:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 19:33 [PATCH v2 0/1] nvme: disable CC.CRIME (NVME_CC_CRIME) gjoyce
2024-10-07 19:33 ` [PATCH v2 1/1] " gjoyce
2024-10-08 15:45 ` Nilay Shroff
2024-10-08 17:35 ` Keith Busch
2024-10-09 7:51 ` Christoph Hellwig
2024-10-09 19:47 ` Keith Busch
2024-10-09 22:04 ` Keith Busch
2024-10-10 16:11 ` Greg Joyce [this message]
2024-10-10 16:16 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d82996a73ba89098bbf2b61733849633612c090a.camel@linux.ibm.com \
--to=gjoyce@linux.ibm.com \
--cc=axboe@fb.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jonathan.derrick@linux.dev \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=msuchanek@suse.de \
--cc=nilay@linux.ibm.com \
--cc=okozina@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox