From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] nvme: fix cns check
Date: Thu, 10 Oct 2024 09:56:33 +0200 [thread overview]
Message-ID: <20241010075633.GB7525@lst.de> (raw)
In-Reply-To: <20241009214035.3851406-1-kbusch@meta.com>
On Wed, Oct 09, 2024 at 02:40:35PM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> The 1.1 spec defined two bits for the Identify CNS field, so such an
> implementation wouldn't be expected to check the full byte for a
> decoding it. Provide a different helper function to make these
> decisions as the existing check only separates the single-bit from the
> two-bit spec versions.
I don't really understand what this is trying to solve. Is there a
controller in the wild reporting 1.1 compliance but reporting useful
information in the NVM Command Set specific Identify Controller data
structure?
next prev parent reply other threads:[~2024-10-10 8:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 21:40 [PATCH] nvme: fix cns check Keith Busch
2024-10-10 7:56 ` Christoph Hellwig [this message]
2024-10-10 15:11 ` Keith Busch
2024-10-11 8:09 ` Christoph Hellwig
2024-10-15 14:36 ` Keith Busch
2024-10-15 15:16 ` Christoph Hellwig
2024-10-15 15:20 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010075633.GB7525@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox