From: Tokunori Ikegami <ikegami.t@gmail.com>
To: linux-nvme@lists.infradead.org
Cc: Tokunori Ikegami <ikegami.t@gmail.com>
Subject: [PATCH] nvme: check PI size if metadata size or below
Date: Wed, 23 Oct 2024 01:34:27 +0900 [thread overview]
Message-ID: <20241022163504.10738-1-ikegami.t@gmail.com> (raw)
The PI is the first bytes or last bytes of the metadata.
So its size is not equal to hte metadata size only but below also.
Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
---
drivers/nvme/host/ioctl.c | 4 ++--
drivers/nvme/host/nvme.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/nvme/host/ioctl.c b/drivers/nvme/host/ioctl.c
index b9b79ccfabf8..9fddaaddbbf1 100644
--- a/drivers/nvme/host/ioctl.c
+++ b/drivers/nvme/host/ioctl.c
@@ -232,8 +232,8 @@ static int nvme_submit_io(struct nvme_ns *ns, struct nvme_user_io __user *uio)
length = (io.nblocks + 1) << ns->head->lba_shift;
- if ((io.control & NVME_RW_PRINFO_PRACT) &&
- (ns->head->ms == ns->head->pi_size)) {
+ if (io.control & NVME_RW_PRINFO_PRACT &&
+ ns->head->ms >= ns->head->pi_size) {
/*
* Protection information is stripped/inserted by the
* controller.
diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
index 093cb423f536..fbcb2243ba84 100644
--- a/drivers/nvme/host/nvme.h
+++ b/drivers/nvme/host/nvme.h
@@ -542,7 +542,7 @@ struct nvme_ns {
/* NVMe ns supports metadata actions by the controller (generate/strip) */
static inline bool nvme_ns_has_pi(struct nvme_ns_head *head)
{
- return head->pi_type && head->ms == head->pi_size;
+ return head->pi_type && head->ms >= head->pi_size;
}
struct nvme_ctrl_ops {
--
2.45.2
next reply other threads:[~2024-10-22 16:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 16:34 Tokunori Ikegami [this message]
2024-10-22 16:54 ` [PATCH] nvme: check PI size if metadata size or below Keith Busch
2024-10-22 17:08 ` Tokunori Ikegami
2024-10-22 17:33 ` Keith Busch
2024-10-22 17:51 ` Tokunori Ikegami
2024-10-22 17:57 ` Keith Busch
2024-10-22 18:12 ` Tokunori Ikegami
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241022163504.10738-1-ikegami.t@gmail.com \
--to=ikegami.t@gmail.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox