From: Keith Busch <kbusch@kernel.org>
To: Tokunori Ikegami <ikegami.t@gmail.com>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: check PI size if metadata size or below
Date: Tue, 22 Oct 2024 11:33:52 -0600 [thread overview]
Message-ID: <ZxfiADxyL-uZYgBf@kbusch-mbp> (raw)
In-Reply-To: <d5735ddc-a3b4-4204-b8fa-b97566f8a91e@gmail.com>
On Wed, Oct 23, 2024 at 02:08:52AM +0900, Tokunori Ikegami wrote:
> The existing function nvme_configure_metadata() code checks as same as below
> but is this checking case only okay?
>
> static void nvme_configure_metadata(struct nvme_ctrl *ctrl,
> struct nvme_ns_head *head, struct nvme_id_ns *id,
> struct nvme_id_ns_nvm *nvm, struct nvme_ns_info *info)
> {
>
> ...
>
> if (head->pi_size && head->ms >= head->pi_size)
> head->pi_type = id->dps & NVME_NS_DPS_PI_MASK;
This is merely checking if the metadata is sufficient to do PI. Nothing
to do with usage of PRACT, which is what you're changing.
next prev parent reply other threads:[~2024-10-22 17:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 16:34 [PATCH] nvme: check PI size if metadata size or below Tokunori Ikegami
2024-10-22 16:54 ` Keith Busch
2024-10-22 17:08 ` Tokunori Ikegami
2024-10-22 17:33 ` Keith Busch [this message]
2024-10-22 17:51 ` Tokunori Ikegami
2024-10-22 17:57 ` Keith Busch
2024-10-22 18:12 ` Tokunori Ikegami
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxfiADxyL-uZYgBf@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=ikegami.t@gmail.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox