From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de,
martin.petersen@oracle.com, joshi.k@samsung.com,
Keith Busch <kbusch@kernel.org>, David Wei <dw@davidwei.uk>
Subject: Re: [PATCH] nvme: module parameter to disable pi checks
Date: Thu, 24 Oct 2024 07:02:39 +0200 [thread overview]
Message-ID: <20241024050239.GA30705@lst.de> (raw)
In-Reply-To: <20241023155048.634988-1-kbusch@meta.com>
On Wed, Oct 23, 2024 at 08:50:48AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> A recent commit enables integrity checks for formats the previous kernel
> versions registered with the "nop" integrity profile. This means
> namespaces using that format become unreadable when upgrading the kernel
> past that commit.
>
> Introduce a module parameter to restore the "nop" integrity profile so
> that storage can be readable once again. This could be a boot device, so
> the setting needs to happen at module load time.
Not exactly a fan of module option, especially with such broad scope.
This will actually disable PI entirely as far as I can tell and not just
for the PI at the end of metadata formats.
Can we at least restrict it to those formats? And maybe add a few
comments in the code why we have all this.
next prev parent reply other threads:[~2024-10-24 5:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20241023162331epcas5p17398e6453b275a480ace5ae5a0176001@epcas5p1.samsung.com>
2024-10-23 15:50 ` [PATCH] nvme: module parameter to disable pi checks Keith Busch
2024-10-23 20:01 ` Chaitanya Kulkarni
2024-10-23 20:21 ` Keith Busch
2024-10-23 21:21 ` David Wei
2024-10-24 1:33 ` Tokunori Ikegami
2024-10-24 5:02 ` Christoph Hellwig [this message]
2024-10-24 15:23 ` Keith Busch
2024-10-24 6:10 ` Kanchan Joshi
2024-10-24 15:19 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241024050239.GA30705@lst.de \
--to=hch@lst.de \
--cc=dw@davidwei.uk \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox